bgpd : Prevent deletion of BGP peer groups associated to listen range

[poojarathore30]

Description:

Deleting a peer group also deletes its associated BGP listen range. This behaviour is undesired as it could cause unintended configuration changes.

Fix :

-Do not allow peer group deletion until they are no longer associated with any listen range.
-Check the count of listen ranges attached to the group. If any listen ranges are found, returns a configuration warning, preventing the deletion.

[ton31337]

Fix styling/formatting also.

[riw777]

looks good ... waiting on other's comments

[ton31337]

Still... styling issues + signed-off is missing.

[ton31337]

Still, styling issues, see:

diff --git a/bgpd/bgp_vty.c b/bgpd/bgp_vty.c
index 1d50e1946..88dc2303b 100644
--- a/bgpd/bgp_vty.c
+++ b/bgpd/bgp_vty.c
@@ -5220,10 +5220,12 @@ DEFUN (no_neighbor_peer_group,
 		for (afi = AFI_IP; afi < AFI_MAX; afi++) {
 			int lr_count = listcount(group->listen_range[afi]);
 			if (lr_count) {
-				vty_out(vty, "%%Peer-group %s is attached to %d listen-range(s), delete them first\n", group->name, lr_count);
+				vty_out(vty,
+					"%%Peer-group %s is attached to %d listen-range(s), delete them first\n",
+					group->name, lr_count);
 				return CMD_WARNING_CONFIG_FAILED;
-				}
 			}
+		}
 		peer_group_notify_unconfig(group);
 		peer_group_delete(group);
 	} else {

[ton31337]

I still have one question. If we do no neighbor PG should it also be prevented from deleting it or only for no neighbor PG peer-group?

[poojarathore30]

I still have one question. If we do no neighbor PG should it also be prevented from deleting it or only for no neighbor PG peer-group?

Yeah true
Ideally if a listen-range is attached to any peer-group, we should prevent it from being deleted whether it's done with
no neighbor PG peer-group or simply no neighbor PG.

Thanks for bringing it up! I'll add the fix for the same.