Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babeld: Add interval and router-id field checking #15698

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zmw12306
Copy link
Contributor

@zmw12306 zmw12306 commented Apr 7, 2024

According to RFC 8966: https://www.rfc-editor.org/rfc/rfc8966.html#name-details-of-specific-tlvs

Add checking for interval and router-id:
The interval MUST NOT be 0 in Acknowledgment Request, IHU, Update

The Router-Id MUST NOT consist of all zeroes or all ones.

Signed-off-by: zmw12306 <zmw12306@gmail.com>
@frrbot frrbot bot added the babel label Apr 7, 2024
@github-actions github-actions bot added size/M master rebase PR needs rebase labels Apr 7, 2024
Signed-off-by: Mingwei Zheng <zmw12306@gmail.com>
@zmw12306
Copy link
Contributor Author

zmw12306 commented Apr 7, 2024

The router-id check should also be done in Seqno Request

@riw777 riw777 self-requested a review April 9, 2024 14:30
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented Apr 30, 2024

This needs to be rebased and the build failure fixed ...

@ton31337
Copy link
Member

@Mergifyio rebase

Copy link

mergify bot commented May 13, 2024

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/1)
Auto-merging babeld/message.c
CONFLICT (content): Merge conflict in babeld/message.c
error: could not apply 4995d1f60... babeld: Add interval and router-id field checking
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 4995d1f60... babeld: Add interval and router-id field checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants