vtysh: fixup incorrect read logic [4.0]

[qlyoung]

If a daemon sent vtysh a response whose size satisfied

1 <= 4096 - (size % 4096) <= 2

vtysh would hang.

Signed-off-by: Quentin Young qlyoung@cumulusnetworks.com

[Jafaral]

@qlyoung I merged the PR that went to master, do you want to fix this so that I push it in as well?

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3273/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for vtysh.c
===============================================
> WARNING: Block comments use a trailing */ on a separate line
> #174: FILE: /tmp/f2/vtysh.c:174:
> +				 * left */
> 
> WARNING: Missing a blank line after declarations
> #210: FILE: /tmp/f2/vtysh.c:210:
> +			char *new;
> +			bufsz *= 2;

---

CLANG Static Analyzer Summary

• Github Pull Request 1988, comparing to Git base SHA 5dd05d6

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3273/artifact/shared/static_analysis/index.html

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3290/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for vtysh.c
===============================================
> WARNING: Block comments use a trailing */ on a separate line
> #170: FILE: /tmp/f2/vtysh.c:170:
> +				 * => don't insert an empty line at the end */
> 
> WARNING: Block comments use a trailing */ on a separate line
> #174: FILE: /tmp/f2/vtysh.c:174:
> +				 * left */
> 
> WARNING: Missing a blank line after declarations
> #210: FILE: /tmp/f2/vtysh.c:210:
> +			char *new;
> +			bufsz *= 2;

---

CLANG Static Analyzer Summary

• Github Pull Request 1988, comparing to Git base SHA 99947b3

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3290/artifact/shared/static_analysis/index.html

[donaldsharp]

@Jafaral is there anything left to do here?

[donaldsharp]

@Jafaral this has been open for 18 days without a review. I am starting the process of pushing this in.

[Jafaral]

Sorry Donald! I have been traveling and didn't get a chance to look at github the past week.