Flowspec other options

[pguibert6WIND]

support for:

ICMP values ( type and code)
DSCP : enumerate or single value
packet length : enumerate or single value or range
fragment : enumerate
tcp flags : enumerate or single value

the enumerate is a OR list.
that implies that there is a demultiplexer in BGP that creates as many pbr ipset and pbr iptable entries as needed.

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4319/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for bgp_pbr.c
===============================================
< WARNING: quoted string split across lines
< #503: FILE: /tmp/f1-8940/bgp_pbr.c:503:
< +				zlog_debug("BGP: match icmp type operations:"
< +					   "too complex. ignoring.");
--
< WARNING: quoted string split across lines
< #515: FILE: /tmp/f1-8940/bgp_pbr.c:515:
< +				zlog_debug("BGP: match icmp code operations:"
< +					   "too complex. ignoring.");
--
< WARNING: quoted string split across lines
< #521: FILE: /tmp/f1-8940/bgp_pbr.c:521:
< +				zlog_debug("BGP: match icmp code is enumerate"
< +					   ", and icmp type is not."
--
< WARNING: quoted string split across lines
< #522: FILE: /tmp/f1-8940/bgp_pbr.c:522:
< +					   ", and icmp type is not."
< +					   " too complex. ignoring.");
--
< WARNING: quoted string split across lines
< #529: FILE: /tmp/f1-8940/bgp_pbr.c:529:
---
> #285: FILE: /tmp/f2-8940/bgp_pbr.c:285:
--
< WARNING: quoted string split across lines
< #556: FILE: /tmp/f1-8940/bgp_pbr.c:556:
< +				zlog_debug("BGP: match DSCP operations:"
< +					   "too complex. ignoring.");
--
< WARNING: quoted string split across lines
< #601: FILE: /tmp/f1-8940/bgp_pbr.c:601:
---
> #295: FILE: /tmp/f2-8940/bgp_pbr.c:295:
--
< WARNING: quoted string split across lines
< #617: FILE: /tmp/f1-8940/bgp_pbr.c:617:
---
> #303: FILE: /tmp/f2-8940/bgp_pbr.c:303:
--
< WARNING: line over 80 characters
< #1454: FILE: /tmp/f1-8940/bgp_pbr.c:1454:
< +				bgp_pbr_policyroute_add_to_zebra_unit(bgp, binfo,
< 

---

CLANG Static Analyzer Summary

• Github Pull Request 2594, comparing to Git base SHA 5ca75c5

No Changes in Static Analysis warnings compared to base

15 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4319/artifact/shared/static_analysis/index.html

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/2594 936f6d1
Date	07/02/2018
Start	03:45:12
Finish	04:08:50
Run-Time	23:38
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-07-02-03:45:12.txt
Log	autoscript-2018-07-02-03:46:17.log.bz2

For details, please contact louberger