Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharp multiple installs #3562

Merged
merged 3 commits into from Jan 8, 2019
Merged

Sharp multiple installs #3562

merged 3 commits into from Jan 8, 2019

Conversation

donaldsharp
Copy link
Member

Add a bit of code to allow us to repeatedly install/uninstall routes in a loop.

@donaldsharp
sharpd: Abstract the route install/delete functions a bit
6b98d34 
Abstract the route install/delete functions a bit to allow me to
expand on them in the with future commits.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
sharpd: Add code to allow install/uninstall repeatedly
b939f6f 
Add a bit of test code to allow the tester to install/uninstall
the routes via:

sharp install routes A.B.C.D nexthop Y.Z.M.D 1000000 repeat 100

This will install 1000000 routes wait for them to be finished
then uninstall them then start installation over 100 times.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com.
@donaldsharp
doc: Update documentation to new functionality
4139089 
Update sharp.rst to reflect new functionality in the `sharp install ..`
command.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jan 3, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/3562 4139089
Date 01/03/2019
Start 10:00:44
Finish 10:24:09
Run-Time 23:25
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-01-03-10:00:44.txt
Log autoscript-2019-01-03-10:01:27.log.bz2

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6306/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for sharp_zebra.c | 10 issues
===============================================
< WARNING: externs should be avoided in .c files
< #135: FILE: /tmp/f1-11959/sharp_zebra.c:135:
< WARNING: externs should be avoided in .c files
< #136: FILE: /tmp/f1-11959/sharp_zebra.c:136:
< WARNING: externs should be avoided in .c files
< #137: FILE: /tmp/f1-11959/sharp_zebra.c:137:
< WARNING: externs should be avoided in .c files
< #138: FILE: /tmp/f1-11959/sharp_zebra.c:138:
< WARNING: Missing a blank line after declarations
< #172: FILE: /tmp/f1-11959/sharp_zebra.c:172:

Warnings Generated during build:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6306/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6306/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6306/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6306/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6306/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6306/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

CLANG Static Analyzer Summary

  • Github Pull Request 3562, comparing to Git base SHA cb6aafa

No Changes in Static Analysis warnings compared to base

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

IPv4 protocols on Ubuntu 14.04: Successful
Topology tests on Ubuntu 16.04 amd64: Successful
CentOS 6 rpm pkg check: Successful
Debian 9 deb pkg check: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
Ubuntu 12.04 deb pkg check: Successful
Static analyzer (clang): Successful
IPv6 protocols on Ubuntu 14.04: Successful
Ubuntu 16.04 deb pkg check: Successful
CentOS 7 rpm pkg check: Successful
Topotest tests on Ubuntu 16.04 i386: Successful
Fedora 24 rpm pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful

Topology tests on Ubuntu 18.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-6307/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-01-03 15:39:08,475 ERROR: 'router_json_cmp' failed after 99.90 seconds
2019-01-03 15:39:08,504 ERROR: assert failed at "test_ldp_vpls_topo1/test_ldp_bindings": "r1" JSON output mismatches the expected result
assert json value is different (
  --- Expected value
  +++ Current value
  @@ -21 +21 @@
  -        "localLabel": "17", 
  +        "localLabel": "18", 
  @@ -29 +29 @@
  -        "localLabel": "17", 
  +        "localLabel": "18", 
  @@ -37 +37 @@
  -        "localLabel": "18", 
  +        "localLabel": "17", 
  @@ -45 +45 @@
  -        "localLabel": "18", 
  +        "localLabel": "17", )
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/TOPOU1804/MemoryLeaks/

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Topology tests on Ubuntu 18.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-6307/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-01-03 15:39:08,475 ERROR: 'router_json_cmp' failed after 99.90 seconds
2019-01-03 15:39:08,504 ERROR: assert failed at "test_ldp_vpls_topo1/test_ldp_bindings": "r1" JSON output mismatches the expected result
assert json value is different (
  --- Expected value
  +++ Current value
  @@ -21 +21 @@
  -        "localLabel": "17", 
  +        "localLabel": "18", 
  @@ -29 +29 @@
  -        "localLabel": "17", 
  +        "localLabel": "18", 
  @@ -37 +37 @@
  -        "localLabel": "18", 
  +        "localLabel": "17", 
  @@ -45 +45 @@
  -        "localLabel": "18", 
  +        "localLabel": "17", )
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Report for sharp_zebra.c | 10 issues
===============================================
< WARNING: externs should be avoided in .c files
< #135: FILE: /tmp/f1-17418/sharp_zebra.c:135:
< WARNING: externs should be avoided in .c files
< #136: FILE: /tmp/f1-17418/sharp_zebra.c:136:
< WARNING: externs should be avoided in .c files
< #137: FILE: /tmp/f1-17418/sharp_zebra.c:137:
< WARNING: externs should be avoided in .c files
< #138: FILE: /tmp/f1-17418/sharp_zebra.c:138:
< WARNING: Missing a blank line after declarations
< #172: FILE: /tmp/f1-17418/sharp_zebra.c:172:

Warnings Generated during build:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

CLANG Static Analyzer Summary

  • Github Pull Request 3562, comparing to Git base SHA cb6aafa

No Changes in Static Analysis warnings compared to base

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for sharp_zebra.c | 10 issues
===============================================
< WARNING: externs should be avoided in .c files
< #135: FILE: /tmp/f1-17418/sharp_zebra.c:135:
< WARNING: externs should be avoided in .c files
< #136: FILE: /tmp/f1-17418/sharp_zebra.c:136:
< WARNING: externs should be avoided in .c files
< #137: FILE: /tmp/f1-17418/sharp_zebra.c:137:
< WARNING: externs should be avoided in .c files
< #138: FILE: /tmp/f1-17418/sharp_zebra.c:138:
< WARNING: Missing a blank line after declarations
< #172: FILE: /tmp/f1-17418/sharp_zebra.c:172:

Warnings Generated during build:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6307/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

CLANG Static Analyzer Summary

  • Github Pull Request 3562, comparing to Git base SHA cb6aafa

No Changes in Static Analysis warnings compared to base

louberger
louberger approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@louberger louberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ready to merge once others have a chance to review.

@louberger louberger added the review & merge me look at me! label Jan 8, 2019
@louberger louberger merged commit f9ad1af into FRRouting:master Jan 8, 2019
@donaldsharp donaldsharp deleted the sharp_multiple_installs branch April 30, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louberger louberger louberger approved these changes

Assignees
No one assigned
Labels
review & merge me look at me!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@donaldsharp @LabN-CI @NetDEF-CI @louberger