build: add check for python-3.8

[mruprich]

In python-3.8, the --embed needs to be added to pythonX.Y-config

Signed-off-by: Michal Ruprich michalruprich@gmail.com

[mruprich]

Python-3.8 will come out soon and there is a change in the python3.8-config that would break any build of FRR. The python3.8-config --ldflags will not produce the expected -lpython3.8. It needs to be python3.8-config --ldflags --embed. I added a check for python3.9 as well just so that we don't have to change this in another couple of months.

More here: https://docs.python.org/dev/whatsnew/3.8.html#debug-build-uses-the-same-abi-as-release-build

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8613/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 8 amd64 build: Failed (click for details)

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8613/artifact/CI008BLD/config.status/config.status Debian 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8613/artifact/CI008BLD/ErrorLog/log_make_dist.txt Debian 8 amd64 build: No useful log found

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8613/artifact/F29BUILD/config.status/config.status Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8613/artifact/F29BUILD/ErrorLog/log_make_dist.txt Fedora 29 amd64 build: No useful log found

Successful on other platforms

• Ubuntu 14.04 amd64 build
• Ubuntu 16.04 amd64 build
• Ubuntu 18.04 amd64 build
• FreeBSD 12 amd64 build
• Ubuntu 16.04 i386 build
• FreeBSD 11 amd64 build
• Ubuntu 18.04 ppc64le build
• NetBSD 6 amd64 build
• OmniOS amd64 build
• CentOS 7 amd64 build
• OpenBSD 6 amd64 build
• NetBSD 7 amd64 build
• Debian 9 amd64 build
• Ubuntu 12.04 amd64 build
• Debian 10 amd64 build

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4836 6914937
Date	08/14/2019
Start	09:15:19
Finish	09:37:07
Run-Time	21:48
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-08-14-09:15:19.txt
Log	autoscript-2019-08-14-09:16:12.log.bz2
Memory	430 423 360

For details, please contact louberger

[qlyoung]

ci:rerun

[qlyoung]

All platform builds completed in CI

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8615/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-8615/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2019-08-14 09:40:30,664 WARNING: BGP is not yet Converged for router r4
2019-08-14 09:40:48,281 WARNING: BGP is not yet Converged for router r1 after bgp clear
2019-08-14 09:47:54,208 WARNING: BGP is not yet Converged for router r1 after bgp clear
*** defaultIntf: warning: r1 has no interfaces
2019-08-14 10:02:38,213 ERROR: ******************************************************************************
2019-08-14 10:02:38,214 ERROR: Test Target Summary                                                  Pass Fail
2019-08-14 10:02:38,214 ERROR: ******************************************************************************
2019-08-14 10:02:38,214 ERROR: FILE: scripts/add_routes.py
2019-08-14 10:02:38,214 ERROR: FILE: scripts/adjacencies.py
2019-08-14 10:02:38,214 ERROR: 20   r3     All adjacencies up                                       0    1
2019-08-14 10:02:38,218 ERROR: See /tmp/topotests/bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity/output.log for details of errors
2019-08-14 10:02:38,222 ERROR: assert failed at "bgp_rfapi_basic_sanity.test_bgp_rfapi_basic_sanity/test_adjacencies": 1 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8615/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Successful on other platforms

• IPv4 ldp protocol on Ubuntu 16.04
• Ubuntu 14.04 deb pkg check
• Addresssanitizer topotest
• Debian 8 deb pkg check
• IPv4 protocols on Ubuntu 14.04
• Debian 9 deb pkg check
• Topotest tests on Ubuntu 16.04 i386
• Static analyzer (clang)
• Topology tests on Ubuntu 18.04 amd64
• Debian 10 deb pkg check
• CentOS 7 rpm pkg check
• IPv6 protocols on Ubuntu 14.04
• Ubuntu 16.04 deb pkg check
• Ubuntu 12.04 deb pkg check
• Fedora 29 rpm pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8615/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

• Github Pull Request 4836, comparing to Git base SHA ce935bc

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8615/artifact/shared/static_analysis/index.html