Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pimd: (*,G) Prune processing doesn't remove SGRpt ifchannel #7404

Merged
merged 1 commit into from Dec 1, 2020
Merged

pimd: (*,G) Prune processing doesn't remove SGRpt ifchannel #7404

merged 1 commit into from Dec 1, 2020

Conversation

vishaldhingra
Copy link
Contributor

@vishaldhingra vishaldhingra commented Oct 28, 2020 •
edited

problem :

When (*,G) prune received where we have SGRpt state,
ifchannel goes to NO_INFO state and doesn't get removed.

Root cause :

During the processing of (*,G) prune, we are not removing the
ifchannel on PruneTmp or PrunePendingTmp state.

Fix :

In that scenario, stop joinExpiry timer and delete the ifchannel.

issue #7347

I have explained the detailed sequence of events on issue #7347.
Please check comment section on issue #7347.

@polychaeta polychaeta added the pim label Oct 28, 2020
@LabN-CI
Copy link
Collaborator

LabN-CI commented Oct 28, 2020 •
edited

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/7404 7f8bc16
Date 10/28/2020
Start 11:17:21
Finish 11:43:44
Run-Time 26:23
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-10-28-11:17:21.txt
Log autoscript-2020-10-28-11:18:21.log.bz2
Memory 503 456 429

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Oct 28, 2020 •
edited

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15024/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15024/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201028-05-g7f8bc1642-0 (missing) -> 7.6-dev-20201028-05-g7f8bc1642-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201028-05-g7f8bc1642-0 (missing) -> 7.6-dev-20201028-05-g7f8bc1642-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201028-05-g7f8bc1642-0 (missing) -> 7.6-dev-20201028-05-g7f8bc1642-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201028-05-g7f8bc1642-0 (missing) -> 7.6-dev-20201028-05-g7f8bc1642-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201028-05-g7f8bc1642-0 (missing) -> 7.6-dev-20201028-05-g7f8bc1642-0~deb10u1

@donaldsharp
Copy link
Member

Please take some time and put in an appropriate commit comment about what you are doing and why

@vishaldhingra @sarav511
pimd: (*,G) Prune processing doesn't remove SGRpt ifchannel
99f9518 
problem :
=========
When (*,G) prune received where we have SGRpt state,
ifchannel goes to NO_INFO state and doesn't get removed.

Root cause :
============
During the processing of (*,G) prune, we are not removing the
ifchannel on PruneTmp or PrunePendingTmp state.

Fix :
=====
In that scenario, stop joinExpiry timer and delete the ifchannel.

issue FRRouting#7347

Co-authored-by: Saravanan K <saravanank@vmware.com>
Signed-off-by: vishaldhingra <vdhingra@vmware.com>
@vishaldhingra vishaldhingra marked this pull request as ready for review November 2, 2020 09:21
@LabN-CI
Copy link
Collaborator

LabN-CI commented Nov 2, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/7404 99f9518
Date 11/02/2020
Start 04:20:37
Finish 04:46:57
Run-Time 26:20
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-11-02-04:20:37.txt
Log autoscript-2020-11-02-04:21:38.log.bz2
Memory 471 478 427

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15110/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15110/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201102-00-g99f9518b4-0 (missing) -> 7.6-dev-20201102-00-g99f9518b4-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201102-00-g99f9518b4-0 (missing) -> 7.6-dev-20201102-00-g99f9518b4-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201102-00-g99f9518b4-0 (missing) -> 7.6-dev-20201102-00-g99f9518b4-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201102-00-g99f9518b4-0 (missing) -> 7.6-dev-20201102-00-g99f9518b4-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201102-00-g99f9518b4-0 (missing) -> 7.6-dev-20201102-00-g99f9518b4-0~deb10u1

@donaldsharp donaldsharp self-requested a review November 17, 2020 16:47
@donaldsharp donaldsharp merged commit fc54da0 into FRRouting:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldsharp donaldsharp Awaiting requested review from donaldsharp

Assignees
No one assigned
Labels
pim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vishaldhingra @LabN-CI @NetDEF-CI @donaldsharp @polychaeta