Fix kernel routes addition with no gateway next-hop IP address #9188

vgrebenschikov · 2021-07-26T14:50:24Z

Fix for Issue #9185

For FreeBSD
It is pretty usual for ptp/tunnel interfaces to add route just to interface, not on gateway IP

Usual way to add such route is:

```# route add 172.22.9.0/24 -iface wg0
add net 172.22.9.0: gateway wg0
```

Interface name sent as GATEWAY in route message, like:
```
RTM_ADD: Add Route: len 240, pid: 4356, seq 1, errno 0, flags:<UP,DONE,STATIC>
locks:  inits:
sockaddrs: <DST,GATEWAY,NETMASK>
 172.22.9.0 wg0 255.255.255.0
```

So, to fix need to do:
1. decode interface name in route message
2. handle interface name/index in kernel routes (by some reason it was just skipped)
3. allow to install kernel routes with empty gateway IP address, but with non-empty interface

Advice?

IPv6 nexthop by ifindex - not sure how to handle properly

polychaeta

Thanks for your contribution to FRR!

One of your commits has an improperly formatted commit message
One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/887bdfcd0238310bc59c2c245e92cda2/raw/6f97a63da465e3fb8dee8be68cd6520e96db33d1/cr_9188_1627311028.diff | git apply

diff --git a/zebra/kernel_socket.c b/zebra/kernel_socket.c
index eec79588f..81ebee046 100644
--- a/zebra/kernel_socket.c
+++ b/zebra/kernel_socket.c
@@ -973,10 +973,10 @@ static int rtm_read_mesg(struct rt_msghdr *rtm, union sockunion *dest,
 			opnt = pnt;
 			pnt += rta_get(pnt, gate, sizeof(*gate));
 			if (!gate->sa.sa_len) {
-                 // No gateway address - interface name instead
-                 pnt = opnt;
-                 pnt += rta_getsdlname(pnt, ifname, ifnlen);
-               }
+				// No gateway address - interface name instead
+				pnt = opnt;
+				pnt += rta_getsdlname(pnt, ifname, ifnlen);
+			}
 			break;
 		case RTA_NETMASK:
 			pnt += rta_getattr(pnt, mask, sizeof(*mask));

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

Fixes: FRRouting#9188 Kernel routes added with no nexthop IP address ignored by zebra It is pretty usual for ptp/tunnel interfaces to add route just to interface, not on gateway IP Usual way to add such route is - route add 172.22.9.0/24 -iface wg0 Missed: - connected and kernel routes may duplicate (need to filter out kernel if already detected as connected) - IPv6 nexthop by ifindex - not sure how to handle properly Signed-off-by: Vladimir Grebenschikov <vova@fbsd.ru>

blocking comments addressed

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/7f544f1334aa187100a7556826a41620/raw/6f97a63da465e3fb8dee8be68cd6520e96db33d1/cr_9188_1627311700.diff | git apply

diff --git a/zebra/kernel_socket.c b/zebra/kernel_socket.c
index eec79588f..81ebee046 100644
--- a/zebra/kernel_socket.c
+++ b/zebra/kernel_socket.c
@@ -973,10 +973,10 @@ static int rtm_read_mesg(struct rt_msghdr *rtm, union sockunion *dest,
 			opnt = pnt;
 			pnt += rta_get(pnt, gate, sizeof(*gate));
 			if (!gate->sa.sa_len) {
-                 // No gateway address - interface name instead
-                 pnt = opnt;
-                 pnt += rta_getsdlname(pnt, ifname, ifnlen);
-               }
+				// No gateway address - interface name instead
+				pnt = opnt;
+				pnt += rta_getsdlname(pnt, ifname, ifnlen);
+			}
 			break;
 		case RTA_NETMASK:
 			pnt += rta_getattr(pnt, mask, sizeof(*mask));

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

Fixes: FRRouting#9188 Kernel routes added with no nexthop IP address ignored by zebra It is pretty usual for ptp/tunnel interfaces to add route just to interface, not on gateway IP Usual way to add such route is - route add 172.22.9.0/24 -iface wg0 Missed: - connected and kernel routes may duplicate (need to filter out kernel if already detected as connected) - IPv6 nexthop by ifindex - not sure how to handle properly Signed-off-by: Vladimir Grebenschikov <vova@fbsd.ru>

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/4a48b3ee44dd2ea8f0e141c1e859bdb7/raw/6f97a63da465e3fb8dee8be68cd6520e96db33d1/cr_9188_1627311832.diff | git apply

diff --git a/zebra/kernel_socket.c b/zebra/kernel_socket.c
index eec79588f..81ebee046 100644
--- a/zebra/kernel_socket.c
+++ b/zebra/kernel_socket.c
@@ -973,10 +973,10 @@ static int rtm_read_mesg(struct rt_msghdr *rtm, union sockunion *dest,
 			opnt = pnt;
 			pnt += rta_get(pnt, gate, sizeof(*gate));
 			if (!gate->sa.sa_len) {
-                 // No gateway address - interface name instead
-                 pnt = opnt;
-                 pnt += rta_getsdlname(pnt, ifname, ifnlen);
-               }
+				// No gateway address - interface name instead
+				pnt = opnt;
+				pnt += rta_getsdlname(pnt, ifname, ifnlen);
+			}
 			break;
 		case RTA_NETMASK:
 			pnt += rta_getattr(pnt, mask, sizeof(*mask));

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

Fixes: FRRouting#9188 Kernel routes added with no nexthop IP address ignored by zebra It is pretty usual for ptp/tunnel interfaces to add route just to interface, not on gateway IP Usual way to add such route is - route add 172.22.9.0/24 -iface wg0 Missed: - connected and kernel routes may duplicate (need to filter out kernel if already detected as connected) - IPv6 nexthop by ifindex - not sure how to handle properly Signed-off-by: Vladimir Grebenschikov <vova@fbsd.ru>

donaldsharp · 2021-07-26T15:43:16Z

this does not work properly yet:

donna# show ip route 
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, T - Table,
       v - VNC, V - VNC-Direct, A - Babel, F - PBR,
       f - OpenFabric,
       > - selected route, * - FIB route, q - queued, r - rejected, b - backup
       t - trapped, o - offload failure

K>* 0.0.0.0/0 [0/0] via 192.168.122.1, vtnet0, 00:00:09
K>* 1.2.3.4/32 [0/0] is directly connected, vtnet0, 00:00:09
K>* 1.2.3.5/32 [0/0] is directly connected, vtnet0, 00:00:09
K>* 1.2.3.6/32 [0/0] is directly connected, vtnet0, 00:00:09
K>* 127.0.0.1/32 [0/0] is directly connected, lo0, 00:00:09
K * 192.168.0.0/16 [0/0] is directly connected, vtnet0, 00:00:09
C>* 192.168.0.0/16 [0/1] is directly connected, vtnet0, 00:00:09
K * 192.168.122.0/24 [0/0] is directly connected, vtnet0, 00:00:09
C>* 192.168.122.0/24 [0/1] is directly connected, vtnet0, 00:00:09
K>* 192.168.122.40/32 [0/0] is directly connected, lo0, 00:00:09
K>* 192.168.122.140/32 [0/0] is directly connected, lo0, 00:00:09
K * 192.168.122.141/32 [0/0] is directly connected, vtnet0, 00:00:09
C>* 192.168.122.141/32 [0/1] is directly connected, vtnet0, 00:00:09
donna#

donaldsharp · 2021-07-26T15:44:55Z

This PR is not properly handling alias routes as kernel -vs- connected.

vgrebenschikov · 2021-07-26T15:50:55Z

This PR is not properly handling alias routes as kernel -vs- connected.
Yes, as I write above, not sure how to fix properly.

LabN-CI · 2021-07-26T16:13:33Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/9188 `5d1c068`
Date	07/26/2021
Start	11:47:51
Finish	12:13:28
Run-Time	25:37
Total	1813
Pass	1813
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-07-26-11:47:51.txt
Log	autoscript-2021-07-26-11:49:07.log.bz2
Memory	511 506 430

For details, please contact louberger

vgrebenschikov · 2021-07-26T16:59:01Z

This PR is not properly handling alias routes as kernel -vs- connected.

Provided additional check, now duplicates are not installed:

srv# sh ip route
C>* 172.22.2.0/24 [0/1] is directly connected, re0, 00:04:13
K>* 172.22.2.5/32 [0/0] is directly connected, lo0, 00:04:13
K>* 172.22.2.6/32 [0/0] is directly connected, lo0, 00:04:13
K>* 172.22.2.7/32 [0/0] is directly connected, lo0, 00:04:13
K>* 172.22.4.0/24 [0/0] via 172.22.4.2, tun0, 00:04:13
K>* 172.22.4.1/32 [0/0] is directly connected, lo0, 00:04:13
C>* 172.22.4.2/32 [0/1] is directly connected, tun0, 00:04:13
C>* 172.22.4.192/32 [0/1] is directly connected, wg0, 00:04:13
K>* 172.22.4.194/32 [0/0] is directly connected, wg0, 00:04:13
K>* 172.22.9.0/24 [0/0] is directly connected, wg0, 00:00:09
C>* 172.22.17.18/32 [0/1] is directly connected, re0, 00:04:13
K>* 172.23.0.0/16 [0/0] via 172.22.4.2, tun0, 00:04:13
K>* 172.24.0.0/23 [0/0] via 172.22.4.2, tun0, 00:04:13
srv#

LabN-CI · 2021-07-26T17:07:43Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/9188 `08b1250`
Date	07/26/2021
Start	12:41:59
Finish	13:07:38
Run-Time	25:39
Total	1813
Pass	1813
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-07-26-12:41:59.txt
Log	autoscript-2021-07-26-12:43:20.log.bz2
Memory	495 507 425

For details, please contact louberger

LabN-CI · 2021-07-26T18:26:49Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/9188 `a8c1090`
Date	07/26/2021
Start	14:01:04
Finish	14:26:43
Run-Time	25:39
Total	1813
Pass	1813
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-07-26-14:01:04.txt
Log	autoscript-2021-07-26-14:02:21.log.bz2
Memory	503 489 418

For details, please contact louberger

NetDEF-CI · 2021-07-26T19:46:53Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20539/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for kernel_socket.c | 20 issues
===============================================
< WARNING: suspect code indent for conditional statements (24, 17)
< #975: FILE: /tmp/f1-5573/kernel_socket.c:975:
< ERROR: code indent should use tabs where possible
< #976: FILE: /tmp/f1-5573/kernel_socket.c:976:
< WARNING: please, no spaces at the start of a line
< #976: FILE: /tmp/f1-5573/kernel_socket.c:976:
< WARNING: C99 // comments do not match recommendation
< #976: FILE: /tmp/f1-5573/kernel_socket.c:976:
< ERROR: code indent should use tabs where possible
< #977: FILE: /tmp/f1-5573/kernel_socket.c:977:
< WARNING: please, no spaces at the start of a line
< #977: FILE: /tmp/f1-5573/kernel_socket.c:977:
< ERROR: code indent should use tabs where possible
< #978: FILE: /tmp/f1-5573/kernel_socket.c:978:
< WARNING: please, no spaces at the start of a line
< #978: FILE: /tmp/f1-5573/kernel_socket.c:978:
< ERROR: code indent should use tabs where possible
< #979: FILE: /tmp/f1-5573/kernel_socket.c:979:
< WARNING: please, no spaces at the start of a line
< #979: FILE: /tmp/f1-5573/kernel_socket.c:979:

NetDEF-CI · 2021-07-26T20:43:46Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20541/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for kernel_socket.c | 20 issues
===============================================
< WARNING: suspect code indent for conditional statements (24, 17)
< #975: FILE: /tmp/f1-21298/kernel_socket.c:975:
< ERROR: code indent should use tabs where possible
< #976: FILE: /tmp/f1-21298/kernel_socket.c:976:
< WARNING: please, no spaces at the start of a line
< #976: FILE: /tmp/f1-21298/kernel_socket.c:976:
< WARNING: C99 // comments do not match recommendation
< #976: FILE: /tmp/f1-21298/kernel_socket.c:976:
< ERROR: code indent should use tabs where possible
< #977: FILE: /tmp/f1-21298/kernel_socket.c:977:
< WARNING: please, no spaces at the start of a line
< #977: FILE: /tmp/f1-21298/kernel_socket.c:977:
< ERROR: code indent should use tabs where possible
< #978: FILE: /tmp/f1-21298/kernel_socket.c:978:
< WARNING: please, no spaces at the start of a line
< #978: FILE: /tmp/f1-21298/kernel_socket.c:978:
< ERROR: code indent should use tabs where possible
< #979: FILE: /tmp/f1-21298/kernel_socket.c:979:
< WARNING: please, no spaces at the start of a line
< #979: FILE: /tmp/f1-21298/kernel_socket.c:979:

NetDEF-CI · 2021-07-26T20:43:54Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20544/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4DEB10AMD64-20544/test

Topology Tests failed for Topotests debian 10 amd64 part 4:

2021-07-26 17:18:54,754 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2021-07-26 17:18:55,115 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2021-07-26 17:18:55,452 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2021-07-26 17:18:55,783 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2021-07-26 17:18:57,647 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 1:a:2 



2021-07-26 17:22:38,642 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



r3: Daemon bgpd not running

From frr r3 bgpd log file:
2021/07/26 17:25:23 BGP: [HG1WF-2N96F] YANG model "ietf-yang-types@*" "*@*"not embedded, trying external file
2021/07/26 17:25:23 BGP: [HG1WF-2N96F] YANG model "ietf-inet-types@*" "*@*"not embedded, trying external file
2021/07/26 17:25:23 BGP: [T83RR-8SM5G] bgpd 8.1-dev starting: vty@2605, bgp@10.0.1.2:179, bgp@10.0.2.1:179
2021/07/26 17:25:24 BGP: [M7Q4P-46WDR] vty[??]@(config)# log file bgpd.log
2021/07/26 17:25:25 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/26 17:25:25 BGP: [M7Q4P-46WDR] vty[??]@# configure terminal
2021/07/26 17:25:25 BGP: [M7Q4P-46WDR] vty[??]@(config)# XFRR_start_configuration
2021/07/26 17:25:25 BGP: [M7Q4P-46WDR] vty[??]@(config)# router bgp 2000 

2021/07/26 17:25:25 BGP: [WNS64-X9NY5][EC 100663299] bind: Cannot assign requested address
2021/07/26 17:25:25 BGP: [HHAYK-1Y778][EC 100663299] bgp_socket: no usable addresses please check other programs usage of specified port 179
2021/07/26 17:25:25 BGP: [VD9ME-QCNTF][EC 100663299] bgp_socket: Program cannot continue

2021-07-26 17:25:27,799 ERROR: assert failed at "test_bgp_listen_on_multiple_addresses/test_peering": r3: Daemon bgpd not running

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20544/artifact/TOPO4DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 8
Topotests debian 10 amd64 part 3
IPv6 protocols on Ubuntu 18.04
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 3
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 8
IPv4 protocols on Ubuntu 18.04
Topotests debian 10 amd64 part 7
Topotests debian 10 amd64 part 9
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 arm8 part 9
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 i386 part 3
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 8
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 arm8 part 5
Static analyzer (clang)
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 4
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 1
CentOS 7 rpm pkg check
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests debian 10 amd64 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4DEB10AMD64-20544/test

Topology Tests failed for Topotests debian 10 amd64 part 4:

2021-07-26 17:18:54,754 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2021-07-26 17:18:55,115 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2021-07-26 17:18:55,452 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2021-07-26 17:18:55,783 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2021-07-26 17:18:57,647 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 1:a:2 



2021-07-26 17:22:38,642 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



r3: Daemon bgpd not running

From frr r3 bgpd log file:
2021/07/26 17:25:23 BGP: [HG1WF-2N96F] YANG model "ietf-yang-types@*" "*@*"not embedded, trying external file
2021/07/26 17:25:23 BGP: [HG1WF-2N96F] YANG model "ietf-inet-types@*" "*@*"not embedded, trying external file
2021/07/26 17:25:23 BGP: [T83RR-8SM5G] bgpd 8.1-dev starting: vty@2605, bgp@10.0.1.2:179, bgp@10.0.2.1:179
2021/07/26 17:25:24 BGP: [M7Q4P-46WDR] vty[??]@(config)# log file bgpd.log
2021/07/26 17:25:25 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/26 17:25:25 BGP: [M7Q4P-46WDR] vty[??]@# configure terminal
2021/07/26 17:25:25 BGP: [M7Q4P-46WDR] vty[??]@(config)# XFRR_start_configuration
2021/07/26 17:25:25 BGP: [M7Q4P-46WDR] vty[??]@(config)# router bgp 2000 

2021/07/26 17:25:25 BGP: [WNS64-X9NY5][EC 100663299] bind: Cannot assign requested address
2021/07/26 17:25:25 BGP: [HHAYK-1Y778][EC 100663299] bgp_socket: no usable addresses please check other programs usage of specified port 179
2021/07/26 17:25:25 BGP: [VD9ME-QCNTF][EC 100663299] bgp_socket: Program cannot continue

2021-07-26 17:25:27,799 ERROR: assert failed at "test_bgp_listen_on_multiple_addresses/test_peering": r3: Daemon bgpd not running

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20544/artifact/TOPO4DEB10AMD64/ErrorLog/log_topotests.txt

Report for kernel_socket.c | 2 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #976: FILE: /tmp/f1-5938/kernel_socket.c:976:

NetDEF-CI · 2021-07-26T20:51:39Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20542/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18I386-20542/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9:

2021-07-26 18:35:34,262 WARNING: vtysh_cmd: r0: failed to convert json output: : No JSON object could be decoded
2021-07-26 18:36:00,439 WARNING: vtysh_cmd: r1: failed to convert json output: : No JSON object could be decoded
2021-07-26 18:39:16,334 ERROR: r0: zebra left a dead pidfile (pid=13864)
2021-07-26 18:39:16,483 ERROR: r3: bgpd left a dead pidfile (pid=14245)
2021-07-26 18:49:21,856 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 1866, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-07-26 18:50:09,831 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 1866, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20542/artifact/TOPO9U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-20542/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6:

2021-07-26 17:07:01,718 ERROR: r3: bgpd left a dead pidfile (pid=8174)
2021-07-26 17:18:43,143 ERROR: 'router_json_cmp' failed after 127.31 seconds
2021-07-26 17:18:43,145 ERROR: assert failed at "bgp_vrf_lite_ipv6_rtadv.test_bgp_vrf_lite_ipv6_rtadv/test_protocols_convergence": "r1" JSON output mismatches
assert Generated JSON diff error report:
  
  > $->2001:db8:1::/64: d1 has Array of length 1 but in d2 it is of length 2
2021-07-26 17:18:43,268 ERROR: r2: bgpd left a dead pidfile (pid=12683)
*** defaultIntf: warning: r1 has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20542/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4U18I386-20542/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4:

2021-07-26 16:57:20,361 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2021-07-26 16:57:20,792 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2021-07-26 16:57:21,261 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2021-07-26 16:57:21,632 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2021-07-26 16:57:23,966 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 1:a:2 



2021-07-26 17:01:37,716 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/26 17:04:32 BGP: [HG1WF-2N96F] YANG model "ietf-yang-types@*" "*@*"not embedded, trying external file
2021/07/26 17:04:32 BGP: [HG1WF-2N96F] YANG model "ietf-inet-types@*" "*@*"not embedded, trying external file
2021/07/26 17:04:32 BGP: [T83RR-8SM5G] bgpd 8.1-dev starting: vty@2605, bgp@10.0.0.1:179
2021/07/26 17:04:33 BGP: [M7Q4P-46WDR] vty[??]@(config)# log file bgpd.log
2021/07/26 17:04:38 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/26 17:04:38 BGP: [M7Q4P-46WDR] vty[??]@# configure terminal
2021/07/26 17:04:38 BGP: [M7Q4P-46WDR] vty[??]@(config)# XFRR_start_configuration
2021/07/26 17:04:38 BGP: [M7Q4P-46WDR] vty[??]@(config)# router bgp 1000 

2021/07/26 17:04:38 BGP: [WNS64-X9NY5][EC 100663299] bind: Cannot assign requested address
2021/07/26 17:04:38 BGP: [HHAYK-1Y778][EC 100663299] bgp_socket: no usable addresses please check other programs usage of specified port 179
2021/07/26 17:04:38 BGP: [VD9ME-QCNTF][EC 100663299] bgp_socket: Program cannot continue

2021-07-26 17:04:42,049 ERROR: assert failed at "test_bgp_listen_on_multiple_addresses/test_peering": r1: Daemon bgpd not running

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20542/artifact/TOPO4U18I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 1
IPv6 protocols on Ubuntu 18.04
Topotests debian 10 amd64 part 8
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 3
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 6
IPv4 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 7
Topotests debian 10 amd64 part 9
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 i386 part 5
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
Debian 9 deb pkg check
IPv4 ldp protocol on Ubuntu 18.04
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 9
Fedora 29 rpm pkg check
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 i386 part 8
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 5
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 5
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 3
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 0

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18I386-20542/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9:

2021-07-26 18:35:34,262 WARNING: vtysh_cmd: r0: failed to convert json output: : No JSON object could be decoded
2021-07-26 18:36:00,439 WARNING: vtysh_cmd: r1: failed to convert json output: : No JSON object could be decoded
2021-07-26 18:39:16,334 ERROR: r0: zebra left a dead pidfile (pid=13864)
2021-07-26 18:39:16,483 ERROR: r3: bgpd left a dead pidfile (pid=14245)
2021-07-26 18:49:21,856 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 1866, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-07-26 18:50:09,831 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 1866, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20542/artifact/TOPO9U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-20542/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6:

2021-07-26 17:07:01,718 ERROR: r3: bgpd left a dead pidfile (pid=8174)
2021-07-26 17:18:43,143 ERROR: 'router_json_cmp' failed after 127.31 seconds
2021-07-26 17:18:43,145 ERROR: assert failed at "bgp_vrf_lite_ipv6_rtadv.test_bgp_vrf_lite_ipv6_rtadv/test_protocols_convergence": "r1" JSON output mismatches
assert Generated JSON diff error report:
  
  > $->2001:db8:1::/64: d1 has Array of length 1 but in d2 it is of length 2
2021-07-26 17:18:43,268 ERROR: r2: bgpd left a dead pidfile (pid=12683)
*** defaultIntf: warning: r1 has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20542/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4U18I386-20542/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4:

2021-07-26 16:57:20,361 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2021-07-26 16:57:20,792 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2021-07-26 16:57:21,261 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2021-07-26 16:57:21,632 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2021-07-26 16:57:23,966 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 1:a:2 



2021-07-26 17:01:37,716 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2575, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/26 17:04:32 BGP: [HG1WF-2N96F] YANG model "ietf-yang-types@*" "*@*"not embedded, trying external file
2021/07/26 17:04:32 BGP: [HG1WF-2N96F] YANG model "ietf-inet-types@*" "*@*"not embedded, trying external file
2021/07/26 17:04:32 BGP: [T83RR-8SM5G] bgpd 8.1-dev starting: vty@2605, bgp@10.0.0.1:179
2021/07/26 17:04:33 BGP: [M7Q4P-46WDR] vty[??]@(config)# log file bgpd.log
2021/07/26 17:04:38 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/26 17:04:38 BGP: [M7Q4P-46WDR] vty[??]@# configure terminal
2021/07/26 17:04:38 BGP: [M7Q4P-46WDR] vty[??]@(config)# XFRR_start_configuration
2021/07/26 17:04:38 BGP: [M7Q4P-46WDR] vty[??]@(config)# router bgp 1000 

2021/07/26 17:04:38 BGP: [WNS64-X9NY5][EC 100663299] bind: Cannot assign requested address
2021/07/26 17:04:38 BGP: [HHAYK-1Y778][EC 100663299] bgp_socket: no usable addresses please check other programs usage of specified port 179
2021/07/26 17:04:38 BGP: [VD9ME-QCNTF][EC 100663299] bgp_socket: Program cannot continue

2021-07-26 17:04:42,049 ERROR: assert failed at "test_bgp_listen_on_multiple_addresses/test_peering": r1: Daemon bgpd not running

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20542/artifact/TOPO4U18I386/ErrorLog/log_topotests.txt

Report for kernel_socket.c | 20 issues
===============================================
< WARNING: suspect code indent for conditional statements (24, 17)
< #975: FILE: /tmp/f1-27006/kernel_socket.c:975:
< ERROR: code indent should use tabs where possible
< #976: FILE: /tmp/f1-27006/kernel_socket.c:976:
< WARNING: please, no spaces at the start of a line
< #976: FILE: /tmp/f1-27006/kernel_socket.c:976:
< WARNING: C99 // comments do not match recommendation
< #976: FILE: /tmp/f1-27006/kernel_socket.c:976:
< ERROR: code indent should use tabs where possible
< #977: FILE: /tmp/f1-27006/kernel_socket.c:977:
< WARNING: please, no spaces at the start of a line
< #977: FILE: /tmp/f1-27006/kernel_socket.c:977:
< ERROR: code indent should use tabs where possible
< #978: FILE: /tmp/f1-27006/kernel_socket.c:978:
< WARNING: please, no spaces at the start of a line
< #978: FILE: /tmp/f1-27006/kernel_socket.c:978:
< ERROR: code indent should use tabs where possible
< #979: FILE: /tmp/f1-27006/kernel_socket.c:979:
< WARNING: please, no spaces at the start of a line
< #979: FILE: /tmp/f1-27006/kernel_socket.c:979:

vgrebenschikov · 2021-07-26T21:26:42Z

Additional consideration about connected routes:

somehow strange connected addresses reflects actual interface configuration:

Example - interface with tree aliases, same network:

$ ifconfig re0
re0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
	options=82099<RXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,WOL_MAGIC,LINKSTATE>
	inet 172.22.2.5 netmask 0xffffff00 broadcast 172.22.2.255
	inet 172.22.2.6 netmask 0xffffff00 broadcast 172.22.2.255
	inet 172.22.2.7 netmask 0xffffff00 broadcast 172.22.2.255

$ netstat -rn | fgrep re0
172.22.2.0/24      link#1             U           re0

3 addresses assigned on interface, one route installed
Looks logical, but in FRR:

$ vtysh -c 'show ip route c' | fgrep re0
C * 172.22.2.0/24 [0/1] is directly connected, re0, 00:01:09
C * 172.22.2.0/24 [0/1] is directly connected, re0, 00:01:14
C>* 172.22.2.0/24 [0/1] is directly connected, re0, 00:09:22

A bit miss-matched with what is on interfaces and in system routing table

Ok, now let's put aliases with /32 netmask:

$ ifconfig re0
re0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
	options=82099<RXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,WOL_MAGIC,LINKSTATE>
	inet 172.22.2.5 netmask 0xffffff00 broadcast 172.22.2.255
	inet 172.22.2.6 netmask 0xffffffff broadcast 172.22.2.6
	inet 172.22.2.7 netmask 0xffffffff broadcast 172.22.2.7

$ netstat -rn | fgrep re0
172.22.2.0/24      link#1             U           re0
172.22.2.6/32      link#1             U           re0
172.22.2.7/32      link#1             U           re0

What is in FRR:

$ vtysh -c 'show ip route c' | fgrep re0
C>* 172.22.2.0/24 [0/1] is directly connected, re0, 00:06:29
C>* 172.22.2.6/32 [0/1] is directly connected, re0, 00:06:29
C>* 172.22.2.7/32 [0/1] is directly connected, re0, 00:06:29

Looks more consistent, but a bit asymmetrical
And last two "loopback" routes are a bit strange ...
in terms of Cisco IOS they should be local routes:

gw#show ip route connected | i GigabitEthernet0/0.1
C        172.22.2.0/24 is directly connected, GigabitEthernet0/0.1
L        172.22.2.1/32 is directly connected, GigabitEthernet0/0.1
L        172.22.2.201/32 is directly connected, GigabitEthernet0/0.1
L        172.22.2.202/32 is directly connected, GigabitEthernet0/0.1

And this looks more "symmetrical", but, probably, this is qustion of other issue.

NetDEF-CI · 2021-07-26T23:13:43Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20550/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for kernel_socket.c | 2 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #976: FILE: /tmp/f1-22458/kernel_socket.c:976:

donaldsharp

I would recommend adding a new function rib_add_kernel_route that we can abstract this problem a bit better.. Yes we have not properly abstracted this but at some point in time in the future we are getting full dplane breakup from having access to rib internals in zebra. This way we centralize all the different data planes we talk to a bit better.

zebra/kernel_socket.c

zebra/rib.h

LabN-CI · 2021-07-27T18:52:22Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/9188 `5847482`
Date	07/27/2021
Start	14:26:52
Finish	14:52:17
Run-Time	25:25
Total	1813
Pass	1813
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-07-27-14:26:52.txt
Log	autoscript-2021-07-27-14:28:07.log.bz2
Memory	511 516 428

For details, please contact louberger

NetDEF-CI · 2021-07-27T22:07:35Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20576/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for kernel_socket.c | 2 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #976: FILE: /tmp/f1-29961/kernel_socket.c:976:

Fixes: FRRouting#9188 Kernel routes added with no nexthop IP address now installed by zebra, excluding these of them who already known as connected It is pretty usual for ptp/tunnel interfaces to add route just to interface, not on gateway IP Usual way to add such route is - route add 172.22.9.0/24 -iface wg0 Signed-off-by: Vladimir Grebenschikov <vova@fbsd.ru>

NetDEF-CI · 2023-07-09T15:57:46Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Redhat 9 amd64 build: Failed (click for details)

Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/RH9BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:16: error: too few arguments to function rib_add
 4250 |         return rib_add(afi, SAFI_UNICAST, vrf_id, ZEBRA_ROUTE_KERNEL, 0, flags,
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 4252 | }
cc1: all warnings being treated as errors

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12812/frr-source'
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U1804AMD64/config.log/config.log.gz

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
 4250 |  return rib_add(afi, SAFI_UNICAST, vrf_id, ZEBRA_ROUTE_KERNEL, 0, flags,
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 4252 | }
cc1: all warnings being treated as errors

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/DEB11AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.12812/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c: In function 'rib_add_kernel_route':
zebra/zebra_rib.c:4250:9: error: too few arguments to function 'rib_add'
 4250 |  return rib_add(afi, SAFI_UNICAST, vrf_id, ZEBRA_ROUTE_KERNEL, 0, flags,
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 4252 | }
cc1: all warnings being treated as errors

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.12812/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.12812/frr-source/doc/user/nexthop_groups.rst
zebra/zebra_rib.c: In function 'rib_add_kernel_route':
zebra/zebra_rib.c:4250:9: error: too few arguments to function 'rib_add'
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI005BUILD/config.status/config.status

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI005BUILD/ErrorLog/log_make.txt)

lib/mgmt_msg.c:643:8: warning: (near initialization for 'su.sa') [-Wmissing-braces]
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4251:10: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12812/frr-source'
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18I386BUILD/config.log/config.log.gz

Redhat 8 amd64 build: Failed (click for details)

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/REDHAT8/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.12812/frr-source/doc/user/nexthop_groups.rst
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/REDHAT8/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.12812/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c:4251:51: error: too few arguments to function call, expected 16, have 15
./zebra/rib.h:364:12: note: 'rib_add' declared here
extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
1 error generated.
gmake[1]: *** [Makefile:10564: zebra/zebra_rib.o] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.12812/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12812/frr-source'
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18ARM8BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12812/frr-source'
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.12812/frr-source/doc/user/nexthop_groups.rst
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
 4250 |  return rib_add(afi, SAFI_UNICAST, vrf_id, ZEBRA_ROUTE_KERNEL, 0, flags,
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 4252 | }
cc1: all warnings being treated as errors

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12812/frr-source'
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:16: error: too few arguments to function rib_add
 4250 |         return rib_add(afi, SAFI_UNICAST, vrf_id, ZEBRA_ROUTE_KERNEL, 0, flags,
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 4252 | }
cc1: all warnings being treated as errors

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U22AMD64BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/DEB10BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.12812/frr-source/doc/user/nexthop_groups.rst
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/DEB10BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12812/frr-source'
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Warnings Generated during build:

Checkout code: Successful with additional warnings

Redhat 9 amd64 build: Failed (click for details)

Redhat 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/RH9BUILD/config.status/config.status

Make failed for Redhat 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/RH9BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:16: error: too few arguments to function rib_add
 4250 |         return rib_add(afi, SAFI_UNICAST, vrf_id, ZEBRA_ROUTE_KERNEL, 0, flags,
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 4252 | }
cc1: all warnings being treated as errors

Redhat 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/RH9BUILD/config.log/config.log.gz

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12812/frr-source'
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U1804AMD64/config.log/config.log.gz

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
 4250 |  return rib_add(afi, SAFI_UNICAST, vrf_id, ZEBRA_ROUTE_KERNEL, 0, flags,
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 4252 | }
cc1: all warnings being treated as errors

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/DEB11AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.12812/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c: In function 'rib_add_kernel_route':
zebra/zebra_rib.c:4250:9: error: too few arguments to function 'rib_add'
 4250 |  return rib_add(afi, SAFI_UNICAST, vrf_id, ZEBRA_ROUTE_KERNEL, 0, flags,
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 4252 | }
cc1: all warnings being treated as errors

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.12812/frr-source/doc/user/pbr.rst:49: WARNING: duplicate label nexthop-groups, other instance in /usr/home/ci/cibuild.12812/frr-source/doc/user/nexthop_groups.rst
zebra/zebra_rib.c: In function 'rib_add_kernel_route':
zebra/zebra_rib.c:4250:9: error: too few arguments to function 'rib_add'
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI005BUILD/config.status/config.status

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI005BUILD/ErrorLog/log_make.txt)

lib/mgmt_msg.c:643:8: warning: (near initialization for 'su.sa') [-Wmissing-braces]
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4251:10: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18I386BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12812/frr-source'
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18I386BUILD/config.log/config.log.gz

Redhat 8 amd64 build: Failed (click for details)

Redhat 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/REDHAT8/config.status/config.status

Make failed for Redhat 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/REDHAT8/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.12812/frr-source/doc/user/nexthop_groups.rst
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Redhat 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/REDHAT8/config.log/config.log.gz

OpenBSD 7 amd64 build: Failed (click for details)

OpenBSD 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/zebra.rst:812: WARNING: duplicate clicmd description of segment-routing, other instance in pathd
/home/ci/cibuild.12812/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c:4251:51: error: too few arguments to function call, expected 16, have 15
./zebra/rib.h:364:12: note: 'rib_add' declared here
extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
1 error generated.
gmake[1]: *** [Makefile:10564: zebra/zebra_rib.o] Error 1
gmake[1]: Leaving directory '/home/ci/cibuild.12812/frr-source'
gmake[1]: Target 'all-am' not remade because of errors.

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12812/frr-source'
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Ubuntu 18.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18ARM8BUILD/config.log/config.log.gz
Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18ARM8BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI021BUILD/config.log/config.log.gz Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12812/frr-source'
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U2004AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.12812/frr-source/doc/user/nexthop_groups.rst
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
 4250 |  return rib_add(afi, SAFI_UNICAST, vrf_id, ZEBRA_ROUTE_KERNEL, 0, flags,
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 4252 | }
cc1: all warnings being treated as errors

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U2004AMD64BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U1804PPC64LEBUILD/config.log/config.log.gz Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12812/frr-source'
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Ubuntu 22.04 amd64 build: Failed (click for details)

Ubuntu 22.04 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U22AMD64BUILD/config.log/config.log.gz

Make failed for Ubuntu 22.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U22AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/zebra.rst:825: WARNING: duplicate clicmd description of locator NAME, other instance in bgp
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:16: error: too few arguments to function rib_add
 4250 |         return rib_add(afi, SAFI_UNICAST, vrf_id, ZEBRA_ROUTE_KERNEL, 0, flags,
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 4252 | }
cc1: all warnings being treated as errors

Ubuntu 22.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U22AMD64BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/DEB10BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.12812/frr-source/doc/user/pbr.rst:31: WARNING: duplicate label nexthop-groups, other instance in /home/ci/cibuild.12812/frr-source/doc/user/nexthop_groups.rst
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Debian 10 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/DEB10BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12812/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.12812/frr-source'
zebra/zebra_rib.c: In function rib_add_kernel_route:
zebra/zebra_rib.c:4250:9: error: too few arguments to function rib_add
In file included from ./zebra/zebra_ns.h:13:0,
./zebra/rib.h:364:12: note: declared here
 extern int rib_add(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
zebra/zebra_rib.c:4252:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Report for kernel_socket.c | 2 issues
===============================================
< WARNING: Block comments use * on subsequent lines
< #1121: FILE: /tmp/f1-2236843/kernel_socket.c:1121:

vgrebenschikov · 2023-07-09T16:04:21Z

I would recommend adding a new function rib_add_kernel_route that we can abstract this problem a bit better.. Yes we have not properly abstracted this but at some point in time in the future we are getting full dplane breakup from having access to rib internals in zebra. This way we centralize all the different data planes we talk to a bit better.

PR was changed according suggestion, also, rebase for more recent version was of master was done

NetDEF-CI · 2023-07-09T18:41:26Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12813/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-12813/test

Topology Tests failed for Topotests debian 10 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12813/artifact/TOPO3DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 3: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12813/artifact/TOPO3DEB10AMD64/TopotestDetails/

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 9
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Debian 9 deb pkg check
Debian 10 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 5
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 8
Static analyzer (clang)
Addresssanitizer topotests part 0
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 9
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 i386 part 5

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests debian 10 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-12813/test

Topology Tests failed for Topotests debian 10 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12813/artifact/TOPO3DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 3: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12813/artifact/TOPO3DEB10AMD64/TopotestDetails/

Report for kernel_socket.c | 2 issues
===============================================
< WARNING: Block comments use * on subsequent lines
< #1121: FILE: /tmp/f1-2655134/kernel_socket.c:1121:

Fixes: FRRouting#9188 Kernel routes added with no nexthop IP address now installed by zebra, excluding these of them who already known as connected It is pretty usual for ptp/tunnel interfaces to add route just to interface, not on gateway IP Usual way to add such route is - route add 172.22.9.0/24 -iface wg0 Signed-off-by: Vladimir Grebenschikov <vova@fbsd.ru>

NetDEF-CI · 2023-07-09T18:51:06Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12814/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_flood_reduction.py`, test `teardown_module`, router `r3`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c0001deff8 at pc 0x5584200ce09d bp 0x7ffeb0f52340 sp 0x7ffeb0f52330
    READ of size 4 at 0x60c0001deff8 thread T0
        #0 0x5584200ce09c in ospf_lsa_lock ospfd/ospf_lsa.c:262
        #1 0x5584201cb1bd in ospf_flood_delayed_lsa_ack ospfd/ospf_flood.c:130
        #2 0x5584201cb1bd in ospf_flood ospfd/ospf_flood.c:537
        #3 0x558420106929 in ospf_ls_upd ospfd/ospf_packet.c:2115
        #4 0x558420106929 in ospf_read_helper ospfd/ospf_packet.c:3198
        #5 0x558420106929 in ospf_read ospfd/ospf_packet.c:3229
        #6 0x558420301184 in event_call lib/event.c:1995
        #7 0x5584202474fb in frr_run lib/libfrr.c:1213
        #8 0x5584200ac164 in main ospfd/ospf_main.c:249
        #9 0x7fac1449dc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #10 0x5584200abac9 in _start (/usr/lib/frr/ospfd+0x2dcac9)
    
    0x60c0001deff8 is located 56 bytes inside of 128-byte region [0x60c0001defc0,0x60c0001df040)
    freed by thread T0 here:
        #0 0x7fac15ca67a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x558420264a3c in qfree lib/memory.c:130
        #2 0x5584200ce45d in ospf_lsa_free ospfd/ospf_lsa.c:256
        #3 0x5584200ce566 in ospf_lsa_unlock ospfd/ospf_lsa.c:279
        #4 0x5584200e0322 in ospf_lsdb_delete_entry ospfd/ospf_lsdb.c:101
        #5 0x5584200e0836 in ospf_lsdb_add ospfd/ospf_lsdb.c:124
        #6 0x5584200d935a in ospf_lsa_install ospfd/ospf_lsa.c:3041
        #7 0x5584200d989b in ospf_summary_lsa_refresh ospfd/ospf_lsa.c:1399
        #8 0x5584200dd6f1 in ospf_lsa_refresh ospfd/ospf_lsa.c:4009
        #9 0x5584200de843 in ospf_refresh_area_self_lsas ospfd/ospf_lsa.c:3785
        #10 0x5584201caf75 in ospf_flood ospfd/ospf_flood.c:517
        #11 0x558420106929 in ospf_ls_upd ospfd/ospf_packet.c:2115
        #12 0x558420106929 in ospf_read_helper ospfd/ospf_packet.c:3198
        #13 0x558420106929 in ospf_read ospfd/ospf_packet.c:3229
        #14 0x558420301184 in event_call lib/event.c:1995
        #15 0x5584202474fb in frr_run lib/libfrr.c:1213
        #16 0x5584200ac164 in main ospfd/ospf_main.c:249
        #17 0x7fac1449dc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7fac15ca6d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x5584202640a8 in qcalloc lib/memory.c:105
        #2 0x5584200cddb6 in ospf_lsa_new ospfd/ospf_lsa.c:186
        #3 0x5584200ce0c0 in ospf_lsa_new_and_data ospfd/ospf_lsa.c:205
        #4 0x558420104b9b in ospf_ls_upd_list_lsa ospfd/ospf_packet.c:1797
        #5 0x558420104b9b in ospf_ls_upd ospfd/ospf_packet.c:1882
        #6 0x558420104b9b in ospf_read_helper ospfd/ospf_packet.c:3198
        #7 0x558420104b9b in ospf_read ospfd/ospf_packet.c:3229
        #8 0x558420301184 in event_call lib/event.c:1995
        #9 0x5584202474fb in frr_run lib/libfrr.c:1213
        #10 0x5584200ac164 in main ospfd/ospf_main.c:249
        #11 0x7fac1449dc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_lsa.c:262 in ospf_lsa_lock
    Shadow bytes around the buggy address:
      0x0c1880033da0: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880033db0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
      0x0c1880033dc0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c1880033dd0: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880033de0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
    =>0x0c1880033df0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd[fd]
      0x0c1880033e00: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880033e10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
      0x0c1880033e20: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
      0x0c1880033e30: 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa fa
      0x0c1880033e40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12814/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12814/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12814/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-12814/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12814/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12814/artifact/TOPO7U18I386/TopotestDetails/

Successful on other platforms/tests

Topotests Ubuntu 18.04 arm8 part 9
Ubuntu 18.04 deb pkg check
Debian 9 deb pkg check
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Static analyzer (clang)
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 5
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 3
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 9
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 arm8 part 4

NetDEF-CI · 2023-07-09T21:41:20Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12815/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Addresssanitizer topotests part 4: Failed (click for details)

## Error: SEGV

### AddressSanitizer error in topotest `ltemplate.py`, test `teardown_module`, router `ce1`

    ERROR: AddressSanitizer: SEGV on unknown address 0x000000005b91 (pc 0x7f0bdafc23a6 bp 0x0000000003fd sp 0x7ffc14dde910 T0)
        #0 0x7f0bdafc23a5  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2a3a5)
        #1 0x7f0bdafc3443  (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2b443)
        #2 0x7f0bdb076772 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde772)
        #3 0x5648c422a0be in qfree lib/memory.c:130
        #4 0x5648c423f38e in nexthop_free lib/nexthop.c:383
        #5 0x5648c423f3c0 in nexthops_free lib/nexthop.c:393
        #6 0x5648c40faa74 in zebra_nhg_free_members zebra/zebra_nhg.c:1609
        #7 0x5648c40faa74 in zebra_nhg_free zebra/zebra_nhg.c:1634
        #8 0x5648c40d4ab4 in mpls_ftn_uninstall_all zebra/zebra_mpls.c:3485
        #9 0x5648c40d56f9 in zebra_mpls_cleanup_zclient_labels zebra/zebra_mpls.c:2527
        #10 0x5648c419731e in hook_call_zserv_client_close zebra/zserv.c:562
        #11 0x5648c419731e in zserv_client_free zebra/zserv.c:581
        #12 0x5648c419731e in zserv_close_client zebra/zserv.c:706
        #13 0x5648c4039b72 in sigint zebra/main.c:156
        #14 0x5648c4299740 in frr_sigevent_process lib/sigevent.c:115
        #15 0x5648c42c43fb in event_fetch lib/event.c:1761
        #16 0x5648c420cb88 in frr_run lib/libfrr.c:1212
        #17 0x5648c403a446 in main zebra/main.c:472
        #18 0x7f0bd986dc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #19 0x5648c4007899 in _start (/usr/lib/frr/zebra+0x2f4899)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV (/usr/lib/x86_64-linux-gnu/libasan.so.4+0x2a3a5) 

---------------

Addresssanitizer topotests part 4: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12815/artifact/ASANP4/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASANP4-12815/test

Topology Tests failed for Addresssanitizer topotests part 4
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12815/artifact/ASANP4/Topotest-Logs/log_topotests.txt

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_flood_reduction.py`, test `teardown_module`, router `r3`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c0001e1f38 at pc 0x56379756709d bp 0x7ffe67672dd0 sp 0x7ffe67672dc0
    READ of size 4 at 0x60c0001e1f38 thread T0
        #0 0x56379756709c in ospf_lsa_lock ospfd/ospf_lsa.c:262
        #1 0x5637976641bd in ospf_flood_delayed_lsa_ack ospfd/ospf_flood.c:130
        #2 0x5637976641bd in ospf_flood ospfd/ospf_flood.c:537
        #3 0x56379759f929 in ospf_ls_upd ospfd/ospf_packet.c:2115
        #4 0x56379759f929 in ospf_read_helper ospfd/ospf_packet.c:3198
        #5 0x56379759f929 in ospf_read ospfd/ospf_packet.c:3229
        #6 0x56379779a184 in event_call lib/event.c:1995
        #7 0x5637976e04fb in frr_run lib/libfrr.c:1213
        #8 0x563797545164 in main ospfd/ospf_main.c:249
        #9 0x7f119f52fc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #10 0x563797544ac9 in _start (/usr/lib/frr/ospfd+0x2dcac9)
    
    0x60c0001e1f38 is located 56 bytes inside of 128-byte region [0x60c0001e1f00,0x60c0001e1f80)
    freed by thread T0 here:
        #0 0x7f11a0d387a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x5637976fda3c in qfree lib/memory.c:130
        #2 0x56379756745d in ospf_lsa_free ospfd/ospf_lsa.c:256
        #3 0x563797567566 in ospf_lsa_unlock ospfd/ospf_lsa.c:279
        #4 0x563797579322 in ospf_lsdb_delete_entry ospfd/ospf_lsdb.c:101
        #5 0x563797579836 in ospf_lsdb_add ospfd/ospf_lsdb.c:124
        #6 0x56379757235a in ospf_lsa_install ospfd/ospf_lsa.c:3041
        #7 0x56379757289b in ospf_summary_lsa_refresh ospfd/ospf_lsa.c:1399
        #8 0x5637975766f1 in ospf_lsa_refresh ospfd/ospf_lsa.c:4009
        #9 0x563797577843 in ospf_refresh_area_self_lsas ospfd/ospf_lsa.c:3785
        #10 0x563797663f75 in ospf_flood ospfd/ospf_flood.c:517
        #11 0x56379759f929 in ospf_ls_upd ospfd/ospf_packet.c:2115
        #12 0x56379759f929 in ospf_read_helper ospfd/ospf_packet.c:3198
        #13 0x56379759f929 in ospf_read ospfd/ospf_packet.c:3229
        #14 0x56379779a184 in event_call lib/event.c:1995
        #15 0x5637976e04fb in frr_run lib/libfrr.c:1213
        #16 0x563797545164 in main ospfd/ospf_main.c:249
        #17 0x7f119f52fc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7f11a0d38d28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x5637976fd0a8 in qcalloc lib/memory.c:105
        #2 0x563797566db6 in ospf_lsa_new ospfd/ospf_lsa.c:186
        #3 0x5637975670c0 in ospf_lsa_new_and_data ospfd/ospf_lsa.c:205
        #4 0x56379759db9b in ospf_ls_upd_list_lsa ospfd/ospf_packet.c:1797
        #5 0x56379759db9b in ospf_ls_upd ospfd/ospf_packet.c:1882
        #6 0x56379759db9b in ospf_read_helper ospfd/ospf_packet.c:3198
        #7 0x56379759db9b in ospf_read ospfd/ospf_packet.c:3229
        #8 0x56379779a184 in event_call lib/event.c:1995
        #9 0x5637976e04fb in frr_run lib/libfrr.c:1213
        #10 0x563797545164 in main ospfd/ospf_main.c:249
        #11 0x7f119f52fc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_lsa.c:262 in ospf_lsa_lock
    Shadow bytes around the buggy address:
      0x0c1880034390: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
      0x0c18800343a0: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c18800343b0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
      0x0c18800343c0: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
      0x0c18800343d0: 00 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa
    =>0x0c18800343e0: fd fd fd fd fd fd fd[fd]fd fd fd fd fd fd fd fd
      0x0c18800343f0: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
      0x0c1880034400: 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa fa
      0x0c1880034410: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
      0x0c1880034420: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
      0x0c1880034430: 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa fa
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12815/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12815/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12815/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12815/artifact/TP3U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP3U1804AMD64-12815/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12815/artifact/TP3U1804AMD64/TopotestLogs/log_topotests.txt

Successful on other platforms/tests

Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 1
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 i386 part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 1
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 5
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 5
Topotests debian 10 amd64 part 9
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 4
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 9

Fixes: FRRouting#9188 Kernel routes added with no nexthop IP address now installed by zebra, excluding these of them who already known as connected It is pretty usual for ptp/tunnel interfaces to add route just to interface, not on gateway IP Usual way to add such route is - route add 172.22.9.0/24 -iface wg0 Signed-off-by: Vladimir Grebenschikov <vova@fbsd.ru>

NetDEF-CI · 2023-07-10T12:51:20Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12828/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-12828/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12828/artifact/TOPO8U18ARM64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12828/artifact/TOPO8U18ARM64/TopotestDetails/

Topotests debian 10 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-12828/test

Topology Tests failed for Topotests debian 10 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12828/artifact/TOPO3DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 3: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12828/artifact/TOPO3DEB10AMD64/TopotestDetails/

Successful on other platforms/tests

Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Addresssanitizer topotests part 8
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 9
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Ubuntu 18.04 deb pkg check
Debian 10 deb pkg check
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Debian 9 deb pkg check
Addresssanitizer topotests part 4
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 0
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 18.04 i386 part 5
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 9
Addresssanitizer topotests part 2
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8U18ARM64-12828/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12828/artifact/TOPO8U18ARM64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 8: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12828/artifact/TOPO8U18ARM64/TopotestDetails/

Topotests debian 10 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3DEB10AMD64-12828/test

Topology Tests failed for Topotests debian 10 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12828/artifact/TOPO3DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 3: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12828/artifact/TOPO3DEB10AMD64/TopotestDetails/

Report for zebra_rib.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #4243: FILE: /tmp/f1-2127776/zebra_rib.c:4243:

Fixes: FRRouting#9188 Kernel routes added with no nexthop IP address now installed by zebra, excluding these of them who already known as connected It is pretty usual for ptp/tunnel interfaces to add route just to interface, not on gateway IP Usual way to add such route is - route add 172.22.9.0/24 -iface wg0 Signed-off-by: Vladimir Grebenschikov <vova@fbsd.ru>

NetDEF-CI · 2023-07-10T20:58:38Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12849/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

github-actions · 2023-08-25T21:36:10Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

polychaeta previously requested changes Jul 26, 2021

View reviewed changes

vgrebenschikov force-pushed the bugfix/kernel-routes-with-no-nexthop branch from 5d1c068 to cf76e46 Compare July 26, 2021 15:01

polychaeta added bugfix zebra labels Jul 26, 2021

polychaeta reviewed Jul 26, 2021

View reviewed changes

vgrebenschikov force-pushed the bugfix/kernel-routes-with-no-nexthop branch from cf76e46 to 0f312b8 Compare July 26, 2021 15:03

polychaeta reviewed Jul 26, 2021

View reviewed changes

vgrebenschikov force-pushed the bugfix/kernel-routes-with-no-nexthop branch from 0f312b8 to 08b1250 Compare July 26, 2021 15:08

vgrebenschikov mentioned this pull request Jul 26, 2021

[FreeBSD] - static routes are not set after raising the interface #3937

Open

2 tasks

donaldsharp requested changes Jul 27, 2021

View reviewed changes

zebra/kernel_socket.c Outdated Show resolved Hide resolved

zebra/rib.h Outdated Show resolved Hide resolved

vgrebenschikov force-pushed the bugfix/kernel-routes-with-no-nexthop branch from a8c1090 to 5847482 Compare July 27, 2021 15:28

github-actions bot added the conflicts label Oct 13, 2022

vgrebenschikov force-pushed the bugfix/kernel-routes-with-no-nexthop branch from 741262e to 5aa2177 Compare July 9, 2023 15:44

github-actions bot added size/M and removed conflicts labels Jul 9, 2023

vgrebenschikov force-pushed the bugfix/kernel-routes-with-no-nexthop branch from 5aa2177 to 998c236 Compare July 9, 2023 15:45

vgrebenschikov force-pushed the bugfix/kernel-routes-with-no-nexthop branch from 998c236 to 1a3a667 Compare July 9, 2023 15:55

vgrebenschikov force-pushed the bugfix/kernel-routes-with-no-nexthop branch from 1a3a667 to fc9d2ad Compare July 9, 2023 18:44

vgrebenschikov force-pushed the bugfix/kernel-routes-with-no-nexthop branch from fc9d2ad to db51caf Compare July 10, 2023 09:49

vgrebenschikov force-pushed the bugfix/kernel-routes-with-no-nexthop branch from db51caf to 2b8548d Compare July 10, 2023 18:00

vgrebenschikov requested a review from polychaeta July 22, 2023 21:04

FRRouting deleted a comment from LabN-CI Jul 26, 2023

github-actions bot added the conflicts label Aug 25, 2023

rzalamena linked an issue Sep 25, 2023 that may be closed by this pull request

Kernel routes missed in case of no gateway IP address #9185

Open

Fix kernel routes addition with no gateway next-hop IP address #9188

Are you sure you want to change the base?

Fix kernel routes addition with no gateway next-hop IP address #9188

Conversation

vgrebenschikov commented Jul 26, 2021 • edited

polychaeta left a comment

Choose a reason for hiding this comment

polychaeta left a comment

Choose a reason for hiding this comment

polychaeta left a comment

Choose a reason for hiding this comment

donaldsharp commented Jul 26, 2021

donaldsharp commented Jul 26, 2021

vgrebenschikov commented Jul 26, 2021

LabN-CI commented Jul 26, 2021 • edited

Basic BGPD CI results: SUCCESS, 0 tests failed

vgrebenschikov commented Jul 26, 2021

LabN-CI commented Jul 26, 2021 • edited

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Jul 26, 2021 • edited

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jul 26, 2021 • edited

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Jul 26, 2021 • edited

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Jul 26, 2021 • edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jul 26, 2021 • edited

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

vgrebenschikov commented Jul 26, 2021 • edited

NetDEF-CI commented Jul 26, 2021 • edited

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

donaldsharp left a comment

Choose a reason for hiding this comment

LabN-CI commented Jul 27, 2021 • edited

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jul 27, 2021 • edited

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Jul 9, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

vgrebenschikov commented Jul 9, 2023

NetDEF-CI commented Jul 9, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jul 9, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Jul 9, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

NetDEF-CI commented Jul 10, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jul 10, 2023

Continuous Integration Result: SUCCESSFUL

vgrebenschikov commented Jul 26, 2021 •

edited

LabN-CI commented Jul 26, 2021 •

edited

LabN-CI commented Jul 26, 2021 •

edited

LabN-CI commented Jul 26, 2021 •

edited

NetDEF-CI commented Jul 26, 2021 •

edited

NetDEF-CI commented Jul 26, 2021 •

edited

NetDEF-CI commented Jul 26, 2021 •

edited

NetDEF-CI commented Jul 26, 2021 •

edited

vgrebenschikov commented Jul 26, 2021 •

edited

NetDEF-CI commented Jul 26, 2021 •

edited

LabN-CI commented Jul 27, 2021 •

edited

NetDEF-CI commented Jul 27, 2021 •

edited