Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to switch to UDP for controls #245

Merged
merged 8 commits into from Sep 3, 2020
Merged

Added option to switch to UDP for controls #245

merged 8 commits into from Sep 3, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2020

  • Added the ROS param UDP_control to switch between UDP and TCP
  • Added docs explaining when to use it

Copy link
Member

@SijmenHuizenga SijmenHuizenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! Let's get all documentation sorted, after that we are ready to merge

docs/getting-started.md Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
Copy link
Member

@SijmenHuizenga SijmenHuizenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for writing this documentation! You really got my mind crunching about how to best explain multi-computer setups and the possible problems that can occur.

You did a great job explaining what people should do. I think we can do an even better job explaining the forces behind the recommendations in an effort to help people make informed decisions about their setup.

At the moment, the Local setup tries to achieve two things:

  1. Explain the two different setups: one where the ROS bridge is running on the simulator computer and one where the ROS bridge runs on the autonomous system computer.
  2. Explain how to get around the WSL bug

To make 1 and 2 super clear, and not scare people who are using both C++ and Python, I suggest we split the two. In this mindset I have re-structured the documentation. I've also moved it into getting-started-with-ros.md as there is more then enough space in there for these docs.

I'm looking forward to hear your opinion on this!

EDIT: Since I am not able to push to your branch I pushed the proposed change here: f00f785

@ghost
Copy link
Author

ghost commented Sep 3, 2020

Looks a lot better indeed, I'll add the changes to the pull request. You should be able to push to the pull request though, the 'allow edits by maintainers' option is checked

@SijmenHuizenga SijmenHuizenga merged commit 25e43d4 into FS-Driverless:master Sep 3, 2020
@SijmenHuizenga SijmenHuizenga linked an issue Sep 3, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ros bridge in WSL breaks publishing nodes
2 participants