Mediawiki 1.26 Standard Pass #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
applehat
commented
Jan 28, 2016
applehat
commented
- MediaWiki Coding Standards
- Replaced raw queries with selects
- General Cleanup of Code
- Added extension.json
- Readme Enhancements
Fixed standards, as well as some actual markup errors. Also just some general code cleanup for readability sake.
This is neither used, or actually does what it says… Just gonna remove it.
Converted raw SQL to select calls.
|
@elifoster I will re-review #18 after this pull request is merged in, and fix any conflicts. I have tested this pull request and it appears to be working, but I'd appreciate it if anyone else would also like to test it out and verify. |
| //$query = "SELECT * FROM $fTableName WHERE `tag_name` = $fItem AND ($fMod = '' OR `mod_name` = $fMod) AND ($mfTag & $fType & `flags`) AND ($mfCall & $fType & `flags`) AND ($mfDisp & $fType & `flags`) AND NOT($fDel & `flags`) $sRand $sLim"; | ||
|
|
||
| $result = $dbr->select( | ||
| $fTableName, |
There was a problem hiding this comment.
Is this double indented or the HTML being off?
There was a problem hiding this comment.
Probably double indented. I'll fix those.
|
This looks pretty good to me. |
|
Yeah, looks pretty alright yo. I tested all 3 of the special pages and their features briefly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.