Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p: define DiscReason as uint8 #78

Merged
merged 1 commit into from
Mar 31, 2023
Merged

p2p: define DiscReason as uint8 #78

merged 1 commit into from
Mar 31, 2023

Conversation

qkta
Copy link

@qkta qkta commented Mar 29, 2023 •
edited

Description

All other implementations store disconnect reason as a single byte, so efsn should do it too.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.

@fjl @qkta
p2p: define DiscReason as uint8
8d97ad7 
All other implementations store disconnect reason as a single byte.
@fanbsb fanbsb merged commit 98ab06b into FUSIONFoundation:develop/5.0.x Mar 31, 2023
@fanbsb
Copy link
Member

fanbsb commented Mar 31, 2023

Thanks for the report, the fix will be include in the next coming verison

@qkta qkta deleted the develop/5.0.x branch March 31, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qkta @fanbsb @fjl