Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write individual files when updated #1

Merged
merged 1 commit into from
Apr 4, 2014
Merged

Conversation

derekerdmann
Copy link
Contributor

Metalsmith now deletes the entire output directory as of metalsmith/metalsmith@15d43a7, so this change restores the ability to update an individual file when it changes without rebuilding everything. Since Metalsmith doesn't have a public method for writing each file, the plugin has to handle that as well.

@FWeinb
Copy link
Owner

FWeinb commented Mar 29, 2014

I think we should rebuild everything now that Metalsmith is deleting the output directory on every build. I am kinda scared that things would get out of sync if we do updates of individual files.

Or do I overlook something?

@derekerdmann
Copy link
Contributor Author

The problem is that when the watcher notifies metalsmith to rebuild a file, it only sends the changed file. The result is that every other file is deleted from the output directory, and only the changed file us rebuilt.

@teddyzetterlund
Copy link

👍

FWeinb added a commit that referenced this pull request Apr 4, 2014
Write individual files when updated
@FWeinb FWeinb merged commit 88a0931 into FWeinb:master Apr 4, 2014
@FWeinb
Copy link
Owner

FWeinb commented Apr 4, 2014

Thanks for this PR, finally got time to merge it. Will be included in version 0.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants