issue-36: Create branch 11.0.0 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jperedadnr
commented
Oct 6, 2018
jperedadnr
commented
- Source/Target compatibility bumped to 1.9
- Core can be used as dependency on any project with Java 9, 10, 11
- Sampler runs standalone in JDK: 9, 10, 11
- Added Launcher class to Sampler to allow running via shadow jar
- Remove private API
- Source/Target compatibility bumped to 1.9 - Core can be used as dependency on any project with Java 9, 10, 11 - Sampler runs standalone in JDK: 9, 10, 11 - Added Launcher class to Sampler to allow running via shadow jar - Remove private API
|
Excellent work as usual Jose. |
Birdasaur
approved these changes
Oct 8, 2018
| dependencies { | ||
| compile "org.openjfx:javafx-graphics:11:win" | ||
| compile "org.openjfx:javafx-graphics:11:linux" | ||
| compile "org.openjfx:javafx-graphics:11:mac" |
There was a problem hiding this comment.
Is adding all 3 platform a requirement for the fat jar?
There was a problem hiding this comment.
Yes, this adds the native libs of all three platforms to the fat jar.
If you don't do this, when you create the jar you will have only the current platform, so the jar won't be cross-platform
There was a problem hiding this comment.
Thanks for clarifying.
build.gradle
Outdated
| repositories { | ||
| jcenter() | ||
| } | ||
|
|
||
| dependencies { | ||
| compile "org.openjfx:javafx-base:11:${platform}" |
There was a problem hiding this comment.
You can get rid of the curly braces surrounding platform
abhinayagarwal
approved these changes
Oct 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.