fix: write lock for warmup #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmetNSimsek
approved these changes
Feb 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
===========================================
+ Coverage 36.81% 53.31% +16.49%
===========================================
Files 61 69 +8
Lines 5421 6645 +1224
===========================================
+ Hits 1996 3543 +1547
+ Misses 3425 3102 -323 ☔ View full report in Codecov by Sentry. |
|
fixed comments @AhmetNSimsek can you take a look again? |
AhmetNSimsek
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since warmup writes files, it is potentially possible to have multiple process trying to warmup simultaneously.
This PR prevents simultaneous write by using a FileLock (or SoftFileLock in windows).