Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backported to 47.1.3 #181

Closed
wants to merge 1 commit into from
Closed

Conversation

smifflepuss
Copy link
Contributor

No description provided.

@Faboslav
Copy link
Owner

Faboslav commented Jan 6, 2024

Why do we need this?

@smifflepuss
Copy link
Contributor Author

smifflepuss commented Jan 6, 2024

Cause some mods like Sully's Mod aren't compatible with 47.1.43 or higher. OK?

@Faboslav
Copy link
Owner

Faboslav commented Jan 6, 2024

Then why dont you make PR for Sully's Mod to bump their forge version?

@smifflepuss
Copy link
Contributor Author

Any version above 47.1.3 broke the jade block behavior for arrows, etc.

@Faboslav
Copy link
Owner

Faboslav commented Jan 6, 2024

Then they should fix the error, forcing other mods to downgrade is not the correct way to resolve this issue.

@Faboslav
Copy link
Owner

Faboslav commented Jan 6, 2024

There is plenty of errors fixed on the forge side between these two versions.

@smifflepuss
Copy link
Contributor Author

You should accept that Urantepus said to us about Sully's Mod. OK?

@Faboslav
Copy link
Owner

Faboslav commented Jan 6, 2024

I dont understand, what do you mean by that?

@Faboslav
Copy link
Owner

Faboslav commented Jan 6, 2024

Are these MosaicModding/Sullys-Mod#15 MosaicModding/Sullys-Mod#48 related to your bug?

@smifflepuss
Copy link
Contributor Author

Yes

@Faboslav
Copy link
Owner

Faboslav commented Jan 6, 2024

These are one year old issues, force the author to do the proper fixes, not me to downgrade the forge version.

@smifflepuss
Copy link
Contributor Author

Well, I don't have any other choice

@Uraneptus
Copy link

Are these Uraneptus/Sullys-Mod#15 Uraneptus/Sullys-Mod#48 related to your bug?

Hi.
The linked issue is not the problem. That's something different. The problem is that forge 47.1.4 brought a breaking change that made our system for the Jade blocks completely useless when using any Projectile that extends the AbstractArrow class.
However we do not enforce using a version of forge below 47.1.4, because the mod is still playable on other version, since pretty much only arrows and tridents break with jade.
And as it was already said, other mods should not be required to change their forge version range for other mods to be compatible with them, so I also consider this PR as not necessary!

@Faboslav
Copy link
Owner

Are these Uraneptus/Sullys-Mod#15 Uraneptus/Sullys-Mod#48 related to your bug?

Hi. The linked issue is not the problem. That's something different. The problem is that forge 47.1.4 brought a breaking change that made our system for the Jade blocks completely useless when using any Projectile that extends the AbstractArrow class. However we do not enforce using a version of forge below 47.1.4, because the mod is still playable on other version, since pretty much only arrows and tridents break with jade. And as it was already said, other mods should not be required to change their forge version range for other mods to be compatible with them, so I also consider this PR as not necessary!

Yeah, then it is settled, since i dropped forge support for 1.20.4+, i can at least check if i can downgrade the version to the mentioned one as one of the last changes on the forge side for me.

@smifflepuss It is possible, that, this will be merged with the next version of friends&foes, we will see.

@smifflepuss
Copy link
Contributor Author

Are these Uraneptus/Sullys-Mod#15 Uraneptus/Sullys-Mod#48 related to your bug?

Hi. The linked issue is not the problem. That's something different. The problem is that forge 47.1.4 brought a breaking change that made our system for the Jade blocks completely useless when using any Projectile that extends the AbstractArrow class. However we do not enforce using a version of forge below 47.1.4, because the mod is still playable on other version, since pretty much only arrows and tridents break with jade. And as it was already said, other mods should not be required to change their forge version range for other mods to be compatible with them, so I also consider this PR as not necessary!

Yeah, then it is settled, since i dropped forge support for 1.20.4+, i can at least check if i can downgrade the version to the mentioned one as one of the last changes on the forge side for me.

@smifflepuss It is possible, that, this will be merged with the next version of friends&foes, we will see.

Well let's port it to 47.1.3 then and see what happens.

@Uraneptus
Copy link

Uraneptus commented Jan 17, 2024

Are these Uraneptus/Sullys-Mod#15 Uraneptus/Sullys-Mod#48 related to your bug?

Hi. The linked issue is not the problem. That's something different. The problem is that forge 47.1.4 brought a breaking change that made our system for the Jade blocks completely useless when using any Projectile that extends the AbstractArrow class. However we do not enforce using a version of forge below 47.1.4, because the mod is still playable on other version, since pretty much only arrows and tridents break with jade. And as it was already said, other mods should not be required to change their forge version range for other mods to be compatible with them, so I also consider this PR as not necessary!

I found a way to handle this. I'm hoping to release a version soon that will work on versions above and below 47.1.4!

@Faboslav
Copy link
Owner

That is good news, i am closing this in favor of the fix, but just in case i was able to lower the requirement(will be released with next update)

@Faboslav Faboslav closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants