Runtime mod remapping in dev #241
Conversation
|
There are some issues with this, that might need some more work from loom's side of things. The mod deps on the classpath are not going to be in the right namespace to handle the remapping of things correctly. I think loom is going to need to pass mc and all of the deps as intermediary jars to be used for remapping. |
|
Is this actually needed anyway ? We can easily |
|
this is not for depending on mods, this is purely for testing with mods. Using flatdir enables you to depend and code against another mod, in a lot of cases this isnt needed. Being able to drop the mods into the mods folder is great when you need to test something quick or just want REI or some simple mod. |
|
The issue is that when you want to test something quick, you often want to get the debugging tools out quickly in case of problems arising. I think something more useful would be a dependency type that is not transitive at all (not declared in maven). |
That's |
|
Those are not transitive ? Well then, is there anything we need other than |
|
I'll note (as was mentioned in Discord earlier) that it may be useful to support jar-in-jars, especially for modpacks. Not critical though, as there are tools to remove them. |
…me_mod_remapping # Conflicts: # src/main/java/net/fabricmc/loader/FabricLoader.java
modmuss50
changed the title
|
This is now ready for review, I have a little more testing to do with it. But so far it seems to be working well. |
| @@ -151,6 +154,100 @@ public void read(BufferedReader reader, String currentNamespace) throws IOExcept | |||
| classes.addAll(parentClasses); | |||
| } | |||
|
|
|||
| public void write(StringWriter writer) { | |||
There was a problem hiding this comment.
I think it might be worth moving access widerners out into their own lib, as all this is copyied right out of loom.
|
|
||
| private final FabricLauncher launcher = FabricLauncherBase.getLauncher(); | ||
|
|
||
| public Collection<ModCandidate> remap(Collection<ModCandidate> modCandidates, FileSystem fileSystem) { |
There was a problem hiding this comment.
Couldn't all the methods in this class effectively be static?
* Export rumtime remap classpath for FabricMC/fabric-loader#241 * Fix bad merge
I tried to cause as little impact to existing parts of the code as possible, this may have lead to things not being ideal.
FabricMC/fabric-loom#277 is required to export the intermediary classpath for this to remap mods against.