Add nether biomes API #496

jaskarth · 2020-02-07T02:34:05Z

Add a new class and mixin to allow modders to inject their own biomes into the nether in a compatible manner.

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/api/biomes/v1/NetherBiomes.java

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/impl/biome/NetherBiomesImpl.java

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/mixin/biome/MixinTheNetherDimension.java

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/impl/biome/NetherBiomesImpl.java

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/api/biomes/v1/NetherBiomes.java

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/mixin/biome/MixinTheNetherDimension.java

coderbot16

Some easy fixes.

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/api/biomes/v1/NetherBiomes.java

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/impl/biome/NetherBiomesImpl.java

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/mixin/biome/MixinTheNetherDimension.java

fabric-biomes-v1/src/main/resources/fabric-biomes-v1.mixins.json

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/impl/biome/NetherBiomesImpl.java

Co-Authored-By: coderbot16 <coderbot16@gmail.com>

…1.16

liach · 2020-02-08T02:47:06Z

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/mixin/biome/MixinTheNetherDimension.java

+import org.spongepowered.asm.mixin.injection.ModifyArg;
+import org.spongepowered.asm.mixin.injection.Redirect;
+
+import net.minecraft.class_4767;


Unused import

coderbot16

One final review, I promise! I think we should just clarify to API users what settings they need to tweak.

coderbot16 · 2020-02-08T02:51:18Z

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/api/biomes/v1/NetherBiomes.java

+	private NetherBiomes() { }
+
+	/**
+	 * Adds a biome to the Nether generator. Biomes must set their own noise generation values in the biome settings class.


Perhaps elaborate on which settings and have a {@link Biome.Settings} as well

Need to detail that you need to set up the biome noise in settings properly or the biomes have literally zero chance to generate in the nether

I think i will add some basic information and then write some detailed explanation on the wiki

liach

Build passes. Style is good.

coderbot16 · 2020-02-08T03:42:59Z

@Earthcomputer can we get a second review from you? Just want to clean up the reviews list :p

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/api/biomes/v1/NetherBiomes.java

Co-Authored-By: coderbot16 <coderbot16@gmail.com> Co-Authored-By: Juuxel <6596629+Juuxel@users.noreply.github.com>

coderbot16 · 2020-02-08T16:32:56Z

I think this is ready for a final review from Player/modmuss. Can @Juuxel give this another look?

coderbot16 · 2020-02-08T16:36:15Z

Almost forgot, we should probably increment the version number to 0.2.0. I'm not sure how this will interact with #491, or if we'll need to bump it to 0.3.0 in the other PR.

Prospector · 2020-02-08T16:44:39Z

Bump to 0.2.0 in both and unless they're merged at the same time, bump the one that was merged last to 0.3.0

2xsaiko · 2020-02-08T17:32:13Z

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/api/biomes/v1/NetherBiomes.java

+/**
+ * API that exposes the internals of Minecraft's nether biome code.
+ */
+public class NetherBiomes {


Everywhere else in API (afaik) this class would be an interface with an INSTANCE field that NetherBiomesImpl implements (see e.g. net.fabricmc.fabric.api.client.model.ModelLoadingRegistry.) Why is this different here?

Not that it makes any real difference, but it would be more consistent.

I wanted to be consistent with the rest of the biome API which follows the same pattern that I used.

Hm, yeah I didn't even notice we did the OverworldBiomes one any differently. Also I noticed in OverworldBiomes we had the class as final, maybe put that here too?

Yeah, if this style exists somewhere previously in API, then fair enough.

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/api/biomes/v1/NetherBiomes.java

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/impl/biome/NetherBiomesImpl.java

modmuss50 · 2020-02-08T18:51:59Z

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/impl/biome/NetherBiomesImpl.java

+/**
+ * Sets for internal use only! Stores data that is used by the Nether dimension mixin.
+ */
+public final class NetherBiomesImpl {


Why make this a class and not add it to InternalBiomeData?

That is a great question if i'm being honest

modmuss50 · 2020-02-08T18:57:56Z

Module also needs to be marked to only run on 1.16+ versions

add 1.16 dependency, merge NetherBiomesImpl into InternalBiomeData, fix code style, and fix mixin target

modmuss50

Implement #499 and then I think this is good to merge.

* Add nether biomes API * Update fabric-biomes-v1.mixins.json * fixed license * smarter injection point * Apply suggestions from coderbot's review Co-Authored-By: coderbot16 <coderbot16@gmail.com> * fix code style * remove redundant import * improve docs and update yarn version * Apply suggestions from code review Co-Authored-By: coderbot16 <coderbot16@gmail.com> Co-Authored-By: Juuxel <6596629+Juuxel@users.noreply.github.com> * bump version * mark classes as final * Changes from modmuss's review add 1.16 dependency, merge NetherBiomesImpl into InternalBiomeData, fix code style, and fix mixin target * Update build.gradle * Update API to inform users that it is experimental * remove beta annotion * optimize imports Co-authored-by: coderbot16 <coderbot16@gmail.com> Co-authored-by: Juuxel <6596629+Juuxel@users.noreply.github.com>

jaskarth added 2 commits February 6, 2020 21:32

Add nether biomes API

c3ce818

Update fabric-biomes-v1.mixins.json

c24ffa2

valoeghese suggested changes Feb 7, 2020

View reviewed changes

fixed license

6d7f755

Earthcomputer suggested changes Feb 7, 2020

View reviewed changes

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/mixin/biome/MixinTheNetherDimension.java Outdated Show resolved Hide resolved

smarter injection point

7e09b20

valoeghese approved these changes Feb 8, 2020

View reviewed changes

coderbot16 suggested changes Feb 8, 2020

View reviewed changes

jaskarth and others added 3 commits February 7, 2020 21:17

Apply suggestions from coderbot's review

5ad7b34

Co-Authored-By: coderbot16 <coderbot16@gmail.com>

fix code style

30241f3

Merge branch '1.16' of https://github.com/SuperCoder7979/fabric into …

ab94055

…1.16

Prospector approved these changes Feb 8, 2020

View reviewed changes

liach added enhancement New feature or request reviews needed This PR needs more reviews labels Feb 8, 2020

liach suggested changes Feb 8, 2020

View reviewed changes

remove redundant import

6ad7d4a

liach requested review from a team and liach February 8, 2020 02:51

coderbot16 suggested changes Feb 8, 2020

View reviewed changes

liach approved these changes Feb 8, 2020

View reviewed changes

improve docs and update yarn version

79b4d9b

coderbot16 approved these changes Feb 8, 2020

View reviewed changes

liach assigned sfPlayer1 Feb 8, 2020

Earthcomputer approved these changes Feb 8, 2020

View reviewed changes

Juuxel suggested changes Feb 8, 2020

View reviewed changes

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/api/biomes/v1/NetherBiomes.java Outdated Show resolved Hide resolved

coderbot16 reviewed Feb 8, 2020

View reviewed changes

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/api/biomes/v1/NetherBiomes.java Outdated Show resolved Hide resolved

Apply suggestions from code review

9e51054

Co-Authored-By: coderbot16 <coderbot16@gmail.com> Co-Authored-By: Juuxel <6596629+Juuxel@users.noreply.github.com>

Prospector added last call If you care, make yourself heard right away! and removed reviews needed This PR needs more reviews labels Feb 8, 2020

Juuxel approved these changes Feb 8, 2020

View reviewed changes

bump version

b8b4c2b

2xsaiko suggested changes Feb 8, 2020

View reviewed changes

mark classes as final

dcc8794

2xsaiko approved these changes Feb 8, 2020

View reviewed changes

modmuss50 requested changes Feb 8, 2020

View reviewed changes

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/api/biomes/v1/NetherBiomes.java Show resolved Hide resolved

fabric-biomes-v1/src/main/java/net/fabricmc/fabric/impl/biome/NetherBiomesImpl.java Outdated Show resolved Hide resolved

modmuss50 reviewed Feb 8, 2020

View reviewed changes

Changes from modmuss's review

2652751

add 1.16 dependency, merge NetherBiomesImpl into InternalBiomeData, fix code style, and fix mixin target

modmuss50 approved these changes Feb 8, 2020

View reviewed changes

jaskarth added 4 commits February 8, 2020 17:07

Update build.gradle

79b7656

Update API to inform users that it is experimental

7381514

remove beta annotion

eb1b4a2

optimize imports

5bfcb28

YanisBft approved these changes Feb 10, 2020

View reviewed changes

modmuss50 merged commit b7436cc into FabricMC:1.16 Feb 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add nether biomes API #496

Add nether biomes API #496

jaskarth commented Feb 7, 2020

coderbot16 left a comment

liach Feb 8, 2020

coderbot16 left a comment

coderbot16 Feb 8, 2020

liach Feb 8, 2020

jaskarth Feb 8, 2020

liach left a comment

coderbot16 commented Feb 8, 2020

coderbot16 commented Feb 8, 2020

coderbot16 commented Feb 8, 2020 •

edited

Prospector commented Feb 8, 2020

2xsaiko Feb 8, 2020

jaskarth Feb 8, 2020

Prospector Feb 8, 2020

jaskarth Feb 8, 2020

2xsaiko Feb 8, 2020

modmuss50 Feb 8, 2020

jaskarth Feb 8, 2020

modmuss50 commented Feb 8, 2020

modmuss50 left a comment

Add nether biomes API #496

Add nether biomes API #496

Conversation

jaskarth commented Feb 7, 2020

coderbot16 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderbot16 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liach left a comment

Choose a reason for hiding this comment

coderbot16 commented Feb 8, 2020

coderbot16 commented Feb 8, 2020

coderbot16 commented Feb 8, 2020 • edited

Prospector commented Feb 8, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modmuss50 commented Feb 8, 2020

modmuss50 left a comment

Choose a reason for hiding this comment

coderbot16 commented Feb 8, 2020 •

edited