Math helper consts / Animation mappings update #3285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Transformation rename relates to #3051. |
enbrain
reviewed
Sep 3, 2022
apple502j
added
the
impactful
|
Would like to have class rename split in a separate PR |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started with me wanting to just map the unknown fields in MathHelper, but then it led me to mapping the methods in there as well.
They're not used by anything (yet) so I've tried my best to document them based on what I can see them doing internally.
That also led me to working on the animation packages. Renamed some packages to be a little more consistent.
i.e.
Transformation->BoneAnimation(based on unobfuscated field names inAnimation)And also
Animation->Timeline(timeline being the technical term for a sequence of animations. Seems to remove some ambiguity of calling them both "animations")Also renamed the corresponding fields in the same package (did not look outside of render/entity/animation - that can rather be another PR) and named some methods that were unmapped based on their usage and what I've learned from looking at the other animation classes whilst doing this PR.