Fix some Modrinth mrpack import issues
#771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's optional, so some files may not have it (like most of FO).
Kinda, it's ugly and hackish, since we don't have the facilities to do this properly (yet!)
people didn't seem to like it, and its not required
|
This pull request introduces 1 alert when merging b3c8f9d into 309013e - view on LGTM.com new alerts:
|
|
seems to work now! |
another oopsie x.x
Scrumplex
reviewed
Jun 11, 2022
Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
reviewed
Jun 11, 2022
Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net>
d-513
approved these changes
Jun 11, 2022
timoreo22
approved these changes
Jun 11, 2022
|
This pull request introduces 1 alert when merging 37160f9 into 9bbf50e - view on LGTM.com new alerts:
|
Scrumplex
approved these changes
Jun 12, 2022
Scrumplex
added a commit
that referenced
this pull request
Jun 12, 2022
Scrumplex
added a commit
that referenced
this pull request
Jun 12, 2022
Scrumplex
added a commit
that referenced
this pull request
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #766 (but CC @DioEgizio test this to be sure, please :p)
Actually, most modpacks weren't working because we were considering the
envfield to be required, but it's optional x.xThe download array is now properly parsed as well, though trying to use the secondary downloads in case the first fails is :pofat: tech ™️, since we don't yet have the proper task mechanisms to do it right (those are being worked on ;) )
This removes the whitelisted hosts check, since people didn't like it and it was causing some issues trying to integrate with multiple download urls anyways
Lastly, this fixes an issue where client overrides where not taken into consideration when importing
mrpacks!