Using multiple DamageInfos/EffectDatas will clear the previous one, even if still in use

[Kefta]

> local info = DamageInfo() info:SetAttacker( Entity(1) ) print( info:GetAttacker() ) local info2 = DamageInfo() print( info:GetAttacker() )...
Player [1][code_gs]
[NULL Entity]

"Why would you ever need more than one?"

https://github.com/ValveSoftware/source-sdk-2013/blob/0d8dceea4310fde5706b3ce1c70609d72a38efdf/mp/src/game/shared/gamerules.cpp#L491-L533

[robotboy655]

It is by design.

[Kefta]

So how do I manage multiple DamageInfos? Store all the values before and restore them?

[bigdogmat]

Is this still a possibility, #860 (comment)?

[ZehMatt]

If this is by design it should be changed to not use the same pointer over and over on the global function, use a memory pool if you are worried about allocation performance.

[FPtje]

An important question here is whose design? GMod's or Source's?

[robotboy655]

Garry's

[ZehMatt]

Just use a circular buffer with a fixed size of 100 or something, this can't be a issue tbh.

[FPtje]

Then surely the developers of GMod should be able to justify this design decision?

[Kefta]

Just so it's not forgotten

I'm not sure how addons would break from that change unless they're doing very weird things with the single instance, but if that's the case, then how about a bool argument to EffectData() and DamageInfo() to create a new instance? false = use the singleton (default), true = new object that is not invalidated across ticks.

[brannanz]

garry made some extremely questionable desicions during the development of gmod