Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more example toml files, also updated all #2

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

DaftPun
Copy link
Contributor

@DaftPun DaftPun commented Jun 10, 2020

toml files to fit new standards for object files properties.

toml files to fit new standards for object files properties.
@DaftPun DaftPun requested a review from tarkatronic June 10, 2020 15:16
@@ -0,0 +1,8 @@
asset_type = "armor"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about an asset_type of "armor". Do we want them to get that fine-grained? I don't necessarily want to hold this PR up on this one thing, but I think this is the point where we should start this discussion, as you brought up in #3. What is our full asset_type list? Do we have asset_types like "armor", or do we use some form of "tagging" to support an entity component system? What would that even look like?

Random brain dump possibility:

asset_type = "item"  # Asset == Entity
asset_components = [
    "wearable"
]

Another example might be:

asset_type = "item"
asset_components = [
    "wearable",
    "container"
]
short_description = "a hoodie with pockets"

I dunno. I'm rambling. I will probably copy this stuff over to #3 to keep the discussion going there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having a tag system is a fine idea. I'll discuss it more on #3.

Copy link
Member

@tarkatronic tarkatronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, seems pretty good to me. I say we get these merged as good beginning examples to give us an idea of what we're working with, and then work on conversations to figure out all of our standards etc. We can always shift things around later if we need to.

@DaftPun DaftPun merged commit e45bd50 into master Jun 17, 2020
@DaftPun DaftPun deleted the assets-update-new-examples branch June 17, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants