Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rcd e #133

Closed
wants to merge 7 commits into from
Closed

Rcd e #133

wants to merge 7 commits into from

Conversation

Emyrk
Copy link
Contributor

@Emyrk Emyrk commented Dec 12, 2019

No description provided.

@WhoSoup WhoSoup added this to In progress in go.mod release (v0.4) via automation Aug 13, 2020
@WhoSoup WhoSoup moved this from In progress to In Review in go.mod release (v0.4) Aug 13, 2020
@PaulBernier
Copy link
Contributor

@Emyrk could you give us the context of this PR? What was the motivation and end purpose?
@WhoSoup we have removed wallet folder from this lib, I don't think we will be able to recover this PR, but we may need to port it to factom-walletd repo, if relevant.

@WhoSoup
Copy link
Member

WhoSoup commented Aug 20, 2020

@Emyrk could you give us the context of this PR? What was the motivation and end purpose?

RCD-e is the ethereum addresses that are needed for the factom<->ethereum gateway. PegNet also uses them for its gateway and right now, the pegnet project uses emyrk's fork as factom lib.

RCD-e isn't inside factomd yet since this would be a hard fork, so the PR likely would have just idled until then.

@PaulBernier
Copy link
Contributor

Good to know this is beeing used, gives some confidence in the testing.
@Emyrk are you willing to help us make the extra push to get this merged into develop? By that I mean resolve conflicts and address potential review commets. It's totally fine to say no if don't want to, but we need to know if we need to re do that PR ourselves or not. Thank you.

@PaulBernier PaulBernier mentioned this pull request Aug 26, 2020
@PaulBernier
Copy link
Contributor

Sounds like we won't be able to move forward with this PR... I created an issue to track that feature request #148

go.mod release (v0.4) automation moved this from In Review to Done Aug 26, 2020
@PaulBernier PaulBernier deleted the rcd-e branch August 27, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants