Merge branch '1.8' into bdcover

.travis.yml

@@ -1,6 +1,6 @@
 language: go
 go:
-        - 1.7.4
+        - 1.8
 before_install:
         - go get github.com/mattn/goveralls
 install:

common/primitives/util.go

@@ -249,9 +249,11 @@ func ConvertECPrivateToUserStr(addr interfaces.IAddress) string {
 func validateUserStr(prefix []byte, userFAddr string) bool {
 	if len(userFAddr) != 52 {
 		return false
-
 	}
 	v := base58.Decode(userFAddr)
+	if len(v) < 3 {
+		return false
+	}
 	if bytes.Compare(prefix, v[:2]) != 0 {
 		return false
 

database/leveldb/leveldb.go

@@ -258,6 +258,8 @@ func NewLevelDB(filename string, create bool) (interfaces.IDatabase, error) {
 
 	opts := &opt.Options{
 		Compression: opt.NoCompression,
+		OpenFilesCacheCapacity: 50,   //this solves the "too many files open problem.  macs have a default of 250 max open files.
+		// setting this lower lessens contention with other programs for the scarce open file limit.
 	}
 
 	tlDB, err = leveldb.OpenFile(filename, opts)

engine/factomd.go

@@ -56,10 +56,6 @@ func Factomd() {
 func isCompilerVersionOK() bool {
 	goodenough := false
 
-	if strings.Contains(runtime.Version(), "1.4") {
-		goodenough = true
-	}
-
 	if strings.Contains(runtime.Version(), "1.5") {
 		goodenough = true
 	}
@@ -71,5 +67,9 @@ func isCompilerVersionOK() bool {
 	if strings.Contains(runtime.Version(), "1.7") {
 		goodenough = true
 	}
+
+	if strings.Contains(runtime.Version(), "1.8") {
+		goodenough = true
+	}
 	return goodenough
 }