Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fd 500 mmr improvements #543

Merged
merged 21 commits into from Aug 30, 2018
Merged

Conversation

factom-clay
Copy link
Contributor

No description provided.

@@ -943,122 +731,131 @@ func (p *ProcessList) Process(state *State) (progress bool) {
last := vm.ListAck[vm.Height-1]
expectedSerialHash, err = primitives.CreateHash(last.MessageHash, thisAck.MessageHash)
if err != nil {
state.LogMessage("process", "Nil out message", vm.List[j])
p.State.LogMessage("process", fmt.Sprintf("nil out message %v/%v/%v, hash INTERNAL_REPLAY", p.DBHeight, i, j), vm.List[j])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be s

state/MMR.go Outdated
// in sim control.
// blocktime in milliseconds
askDelay := int64(s.DirectoryBlockInSeconds * 1000)
// Take 1/10 of 1 minute boundary (DBlock is 10*min)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1/5th

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 44.764% when pulling b3bb183 on FD-500_MMR_Improvments into 0f851f9 on FD-622_TestingRollup2.

@carryforward carryforward merged commit 86af249 into FD-622_TestingRollup2 Aug 30, 2018
@PaulBernier PaulBernier deleted the FD-500_MMR_Improvments branch September 26, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants