Fd 926 sim test cleanup #687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt. Fixed TestCreatEntriesBeforeChain.
…mount. Changed so simwallet transation logged to simwallet.txt, made debug files off by default
…ting on the wrong state.
Fd 928 db state missing err
factom-clay
requested review from
carryforward
and removed request for
michaelbeam and
factom-clay
|
rolled changes into this PR #756 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code looks good to me - though b/c I created the PR I can't approve.
EDIT: except for failing tests... :( if we'd like I continue to resolve in #FD-908 - which I'm still tweaking