Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fd 960 dbck ablock duplicates #703

Closed
wants to merge 11 commits into from
Closed

Fd 960 dbck ablock duplicates #703

wants to merge 11 commits into from

Conversation

michaelbeam
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 43.814% when pulling 0fc8881 on FD-960_dbck_ablock_duplicates into 35285be on FD-968_release_candidate_bond.

Emyrk
Emyrk requested changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this missing a lot of the original DatabaseIntegrityCheck code?
It is not checking entries, commits, or eblocks.

Also is there a reason the file was renamed? It makes reviewing changes difficult.

@stackdump stackdump closed this Oct 18, 2019
@PaulBernier PaulBernier deleted the FD-960_dbck_ablock_duplicates branch September 26, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emyrk Emyrk Emyrk requested changes

@carryforward carryforward Awaiting requested review from carryforward

Assignees

@michaelbeam michaelbeam

@carryforward carryforward

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@michaelbeam @coveralls @Emyrk @stackdump @carryforward