Added of date for data commit entry to endpoint "ack"

[ilzheev]

Our core developer added transactiondate & transactiondatestring into factomd API ack response.

So, ack of entry now contains the timestamp of entry creation (transaction).
Looks like this timestamp existed in entry-ack, but was lost during refactoring from entry-ack → ack, now we return it back.

I have tested it and it works correctly.

Example of improved API response:

{"jsonrpc":"2.0","id":0,"result":{"committxid":"7a86efb415f4eecb3eb2c7733e3fa7edc01541b8dcbc82700e06d19d283fed39","entryhash":"0d835d5f3a9ef33b1955506d6c452430f4aa5f839d98e0a75a58249829260987","commitdata":{"transactiondate":1564044424749,"transactiondatestring":"2019-07-25 12:47:04","status":"DBlockConfirmed"},"entrydata":{"blockdate":1564044300,"blockdatestring":"2019-07-25 12:45:00","status":"DBlockConfirmed"}}}

[PaulBernier]

the datestring is redundant information with the timestamp and less flexible. It should be the responsibility of the client to format the time to a string as it pleases him/her. Basically I think the datestring should be simply dropped.

[ilzheev]

the datestring is redundant information with the timestamp and less flexible. It should be the responsibility of the client to format the time to a string as it pleases him/her. Basically I think the datestring should be simply dropped.

I agree with that, but from the consistency side it should be there.
There is datestring for entrydata:

…
"entrydata": {
"blockdate":1564044300,
"blockdatestring":"2019-07-25 12:45:00",
…

So, Michael added transactiondate & transactiondatestring, so both commitdata & entrydata will be consistent.

[ilzheev]

We are preparing a proposal for refactoring of ack call, the drop of datestring's should be discussed there IMO.

[PaulBernier]

Oh, ok, I didn't realize that there was originally already a datestring field.

[Emyrk]

LG

[ilzheev]

@stackdump @Emyrk Hey, I'm testing v6.4.2-rc2-alpine and looks like this PR is not included there. Can we include it into final Xuan release?

[stackdump]

added another pr: #885 to pull this commit into rollup 3