Fix issues in Wine #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the most common issues when running USB Helper in Wine by patching a few things and setting some default values.
Wine is detected by checking if
ntdllexportswine_get_version; Wine compatibility mode can also be enabled manually by passing--wineto the launcher.Changes:
ForceHttp = trueandIPCType = IPCType.TCPby defaultSoftwareOnly, which fixes a crash related to the speed graphwine-stagingis recommended, as it's currently significantly faster thanwine-stable.I've also created a docker image based on Ubuntu 18.04 + wine-staging + .NET 4.8 here, which can run USB Helper using this + #68 and display it over a local VNC connection.
(These changes depend on TCP IPC bindings, included in #68)