Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FairModule::AddSensitiveVolume searches volume set twice #1495

Open
dennisklein opened this issue Mar 3, 2024 · 0 comments
Open

FairModule::AddSensitiveVolume searches volume set twice #1495

dennisklein opened this issue Mar 3, 2024 · 0 comments
Labels

Comments

@dennisklein
Copy link
Member

386912e introduced a double linear search of the volume on vList in FairModule::AddSensitiveVolume:

  1. search happens here
  2. search happens here, see FairVolumeList::addVolume

Possible fix involves changing the error behaviour of FairVolumeList::addVolume to return the failure to add to the caller, e.g. by returning a pointer to the added volume (which is nullptr in case of not adding it).

@dennisklein dennisklein added the bug label Mar 3, 2024
dennisklein added a commit to dennisklein/FairRoot that referenced this issue Mar 4, 2024
This was referenced Mar 4, 2024
dennisklein added a commit to dennisklein/FairRoot that referenced this issue May 24, 2024
dennisklein added a commit to dennisklein/FairRoot that referenced this issue May 24, 2024
dennisklein added a commit to dennisklein/FairRoot that referenced this issue May 26, 2024
dennisklein added a commit to dennisklein/FairRoot that referenced this issue May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant