New way to setup Event Display by XML files. #1386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi!
As I already noted, this changeset is too big for me, to really review it quickly. Some ideas to split this up into digestable pieces:
FairEveTracks.*looks like a nice, general cleanup. Easy for a dedicated PR.- FairXMLPdgColor and its base class also look quite digestable. It could be used to perform a temporary refactoring of FairEventManager in a non-API breaking manor?
Comment on lines
+31
to
+33
| FairXMLPdgColor(FairXMLNode* node = nullptr); | ||
| Int_t GetColor(Int_t pdg) const; | ||
| ~FairXMLPdgColor() override; |
There was a problem hiding this comment.
Suggested change
| FairXMLPdgColor(FairXMLNode* node = nullptr); | |
| Int_t GetColor(Int_t pdg) const; | |
| ~FairXMLPdgColor() override; | |
| explicit FairXMLPdgColor(FairXMLNode* node = nullptr); | |
| Int_t GetColor(Int_t pdg) const; | |
| ~FairXMLPdgColor() override = default; |
We haven't official adopted CPPCG::C.46, but I think, it would be a good idea.
I think, the destructor is completely empty in the .cxx, so let's go for a = default one here, maybe?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
again I'm trying to use XML to remove configuration of tracks/detectors from FairRoot Event Display
Mention any issue this PR resolves or is related to.
Checklist: