Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp e2e Tests #118

Merged
merged 6 commits into from
Mar 6, 2020
Merged

Revamp e2e Tests #118

merged 6 commits into from
Mar 6, 2020

Conversation

sudermanjr
Copy link
Member

@sudermanjr sudermanjr commented Mar 2, 2020

  • Adding a docker build + kind load command to the e2e test in order to enable external PRs
  • Switch to venom for e2e tests
  • Add test output of e2e tests. Tied to rok8s-scripts PR
  • Added additional test validation

TODO:

  • Split the 10_ test case into more than one
  • Move the installation of the demo app into the test suite of the tests it applies to and cleanup after
  • Release orb so that saving the output works
  • Actually fail the build if the tests fail.
  • Still report the tests to circle even if the tests fail.

@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   43.39%   43.39%           
=======================================
  Files           8        8           
  Lines         553      553           
=======================================
  Hits          240      240           
  Misses        302      302           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe3f93f...152b0f3. Read the comment docs.

@sudermanjr sudermanjr changed the title Adding a kind load command to the e2e test in order to enable external PRs Revamp e2e Tests Mar 3, 2020
@sudermanjr sudermanjr force-pushed the sudermanjr/external-e2e-tests branch 2 times, most recently from 7851a32 to f922ba0 Compare March 3, 2020 18:39
@sudermanjr sudermanjr force-pushed the sudermanjr/external-e2e-tests branch from 96a8830 to 5cb509e Compare March 3, 2020 20:42
@sudermanjr sudermanjr merged commit e635d2a into master Mar 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the sudermanjr/external-e2e-tests branch March 6, 2020 00:43
hjkatz added a commit to hjkatz/goldilocks that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant