Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reckoner 6.0.0-rc4 does not interpolate environment variables in release values #575

Closed
2 tasks done
ivanfetch-wt opened this issue Apr 20, 2022 · 2 comments · Fixed by #576
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@ivanfetch-wt
Copy link

What happened?

The Helm release shows $VariableName in values, instead of the value of sed environment variable.

What did you expect to happen?

The value of the environment variable should be reflected in the Helm values.

How can we reproduce this?

Using this Course:

schema: v2
namespace: test
repositories:
  fairwinds-stable:
    url: https://charts.fairwinds.com/stable
namespace_management:
  default:
    settings:
      overwrite: false
releases:
  - name: rbac-manager
    namespace: rbac-manager
    namespace_management:
      settings:
        overwrite: false
    chart: rbac-manager
    version: 1.11.0
    repository: fairwinds-stable
    values:
      pointless: $INSIGHTS_URI

The INSIGHTS_URI environment variable is set to something:

$ echo $INSIGHTS_URI
https://xxxxx.k8s.insights.fairwinds.com

After reckoner plot -a test.yaml, looking at the helm values for brac-manager shows the name of the environment variable, not its value:

helm get values -n rbac-manager rbac-manager
USER-SUPPLIED VALUES:
pointless: $INSIGHTS_URI

Version

Version:6.0.0-rc.4 Commit:a163b28e538952188d12186b4f8a8562cc365708

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@ivanfetch-wt ivanfetch-wt added bug Something isn't working triage This bug needs triage labels Apr 20, 2022
@sudermanjr sudermanjr self-assigned this Apr 21, 2022
@sudermanjr
Copy link
Member

I think I have a test case that will address this working. Trying to find a fix.

@sudermanjr sudermanjr removed the triage This bug needs triage label Apr 21, 2022
@sudermanjr sudermanjr mentioned this issue Apr 21, 2022
3 tasks
@sudermanjr
Copy link
Member

Turns out, the key is starting with a v2 schema.

This bug only presents when using a v2 course file directly, not when using a converted file. The e2e tests only currently cover converted files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants