Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env vars in Go #576

Merged
merged 5 commits into from
Apr 22, 2022
Merged

Fix env vars in Go #576

merged 5 commits into from
Apr 22, 2022

Conversation

sudermanjr
Copy link
Member

@sudermanjr sudermanjr commented Apr 21, 2022

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Fixes #575

TODO:

  • Add e2e tests that cover v2 schema. This is how we missed it.

What changes did you make?

Fix missing recursion for course parsing in v2 schema

@sudermanjr sudermanjr changed the title This PR fixes # Fix env vars in Go Apr 21, 2022
pkg/course/course.go Outdated Show resolved Hide resolved
pkg/course/course.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sudermanjr sudermanjr merged commit 3e7c741 into master Apr 22, 2022
@sudermanjr sudermanjr deleted the sudermanjr/env-var branch April 22, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reckoner 6.0.0-rc4 does not interpolate environment variables in release values
2 participants