Add optional GCP_IMG_REPO #427
Merged
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional env var to specify an individual GCR registry to use. If left blank the GCP default is used. The gcp default contains the following registries. ``` gcr.io, asia.gcr.io, eu.gcr.io, us.gcr.io ```
|
|
|
I ran this in a local container to verify that it works as intended. I set GCP_IMG_REPO=us.gcr.io and also edited my config.json to only pull from the us repo. Ran this test with the defaults and the Warning message shows up whether we specify one repo or all the repos. |
nungster
approved these changes
Oct 4, 2022
sudermanjr
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional env var to specify an individual GCR registry to use. If left blank the GCP default is used.
The gcp default contains the following registries.
This PR fixes #
Checklist
Description
What's the goal of this PR?
What changes did you make?
What alternative solution should we consider, if any?