[pull] main from chromium:main #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
MultiInstanceState manages the multi-instance state of Chrome. It
is configured by MultiInstanceManagerApi31 to track ChromeTabbed-
Activity-based tasks.
- isInMultiInstanceMode(): true if multiple instances are visible
on screen.
Also MultiInstanceStateObserver can be used to get notified of multi-
instance state whenever the state is flipped.
Bug: 1270978, 1232126
Change-Id: Ib26083fd9f6cfad06b3bd06d0a3c40c6b6c82b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3261418
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Commit-Position: refs/heads/main@{#948473}
This reverts commit cdedf74. Reason for revert: crbug.com/1276899 Original change's description: > Calendar view Animation polish > > 1, starts the header animation in the middle of the month views' > animation when the current gets changed. (Previous we updated the header > with animation after the month views' animation is finished). This could > be done by several approaches: > a.(selected) When the month views's animation has started for 300ms > (which is half of the total animation duration), starts the header > animation. See screen record: > https://drive.google.com/file/d/1ndFYna_HEZV9l09-5s56jowWy0UT24S4/view?usp=sharing > b. first starts an animation to scroll the month views to the > top/bottom of the current month, then starts the header animation in the > scroll animation `OnEnded()` callback, then start the rest of the scroll > animation. This approach makes the scroll animation look disconnected > between the 2 animations. See screen record: > https://drive.google.com/file/d/1-gyt43CN2Srk6_7VhoB77vMOKmBPHqzX/view?usp=sharing > > 2, makes the header animation and the month views' animation in act in > the same direction > > 3, disable the header animation when the scroll is not preformed by > buttons. > > > Bug: 1254491 > Change-Id: I7a5a2cce019e11afd9610a7ea7aa0cb08b4736ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299211 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Jiaming Cheng <jiamingc@chromium.org> > Cr-Commit-Position: refs/heads/main@{#947781} Bug: 1254491 Change-Id: I14047cf68065d0860769cf8b6405d095db9ffa60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314825 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Owners-Override: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/main@{#948474}
Transform the face rectangle coordinates taking into account the letterbox or pillarbox cropping from the active sensor array to the canvas resolution. Bug: b:207642741 Test: Manually on device using CCA expert mode. Change-Id: Ie0c62c45037463a34fbf2206f3ffe1c7aad67ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3303003 Reviewed-by: Wei Lee <wtlee@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/main@{#948475}
Profile::IsSupervised was previously used to support the legacy supervised users account type in ChromeOS. This type has been deprecated in M74 and accounts have been actively deleted since M89. The low number of device accounts with this user type along with the fact that the active deletion does not use Profile::IsSupervised means that we can safely merge this method back into Profile::IsChild. Bug: 1275169 Change-Id: Id7013ed11089836492b6452a595343831db7ad38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310680 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/main@{#948476}
Change-Id: Ib8d378f6db2106240c717924cf7c695b3a01e2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314593 Commit-Queue: Olga Sharonova <olka@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Reviewed-by: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/main@{#948477}
Roll Chrome Win64 PGO profile from chrome-win64-main-1638770344-5a55deeab7112e4371804967bf3d58c157c1b315.profdata to chrome-win64-main-1638780863-ad3a47555d8a1a75d7fa6dc0ecdcde3a1c0abe82.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5fc286ffa064f3f5bb82d2123cdd68a8906af73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317358 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948478}
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_nightly_202112060100_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/i7EK97odXDVeEHF291--ccszH_Vpi_gJmwR1xWlKrL8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll Please CC cros-projector-oncall@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: cros-projector-oncall@grotations.appspotmail.com Change-Id: I5b61a7e6ab71f22ab4c71fe6b5cb5c6f3337696b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317356 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948479}
This reverts commit 4cbdc91. Reason for revert: causes StrictModePolicyViolation test failures https://crbug.com/1276907 Original change's description: > [DesktopSite] Persist tab level user agent setting to disk > > Add a new user agent field to TabState and CriticalPersistedTabData. > This is to preserve the tab level Request Desktop Site setting after > Clank restart. > > Bug: 1251794 > Change-Id: Ic3fa701fbb9d75700a7c0f7f4aeed623a9e01353 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298954 > Reviewed-by: David Maunder <davidjm@chromium.org> > Reviewed-by: Theresa Sullivan <twellington@chromium.org> > Commit-Queue: Shu Yang <shuyng@google.com> > Cr-Commit-Position: refs/heads/main@{#947718} Bug: 1251794, 1276907 Change-Id: I8349aa7dbad29963e016afc511eb7bcdc228501b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314913 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Alex Ilin <alexilin@google.com> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/main@{#948480}
Currently ExtensionPinningTest tests have the logic for writing the response for fetching update manifest in the test itself. This CL moves the common logic into a method. Bug: b/182887200 Change-Id: I2918d3be66ac7173f9f0c99e25268bcf2c11b48e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314566 Reviewed-by: Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/main@{#948481}
This patch: 1. Implements functionality in AXPosition that finds sentence boundaries. 2. Ensures that consistent boundaries are provided on all platforms by routing all "find boundary" requests through AXPosition. 3. Stops relying on the BrowserAccessibility delegate to find text boundaries. This will enable Views to also make use of AXPosition. 4. Stops using ax_text_utils, with the aim of removing this file in a followup patch. R=aleventhal@chromium.org AX-Relnotes: n/a. Change-Id: I90d946c4e5cd901ab4d5626f0d226e0f49b9b87b Bug: 1049261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3275773 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/main@{#948482}
https://android.googlesource.com/platform/external/perfetto.git/+log/e9e81c015296..c949b5f8e83d 2021-12-06 octaviant@google.com Merge "ui: Fix dependency issue causing build failure" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia1b383fbee440e66c1184431e44214b69f439517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317359 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948483}
This adds a reusable component that evaluates JS flows in a sandbox environment. It is not yet hooked up to autofill_assistant, that will be done in a follow-up. Bug: b/201970915 Change-Id: I49752f4e5e6ebd673c1e621e04698e3600f07a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298127 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by: Sandro Maggi <sandromaggi@google.com> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/main@{#948484}
This CL updates the design of the bubble that is shown when the device returns from sleep, low brightness or the lock screen. It now uses a SubtleNotificationView so that it matches the design of the bubble that is shown in the browser when entering full screen mode. Bug: b:203501653 Change-Id: I0686d0c1bea4096541c1efda44c3b4e5ad77dd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298026 Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Anina Koehler <aninak@google.com> Cr-Commit-Position: refs/heads/main@{#948485}
https://chromium.googlesource.com/catapult.git/+log/32ccf2128427..02439f647cbd 2021-12-06 robertlin@chromium.org CodeHealth: Run Pylint 2.7 in catapult/common/py_utils/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1262295 Tbr: nuskos@google.com Change-Id: I4c1d49a3d86922139fc0936083536e18a6eddf77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3316942 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948486}
CopyRGBATextureToVideoFrame() deals with mailboxes and not VideoFrame objects, so we must manually copy timestamp and metadata over to the destination frame from the source frame. R=eugene, ilnik Fixed: 1275376 Change-Id: I3a7cbd004dddd5a40bca37a9a87fa64df5d31a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315342 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#948487}
Bug: 1226006 Change-Id: Ifd062a1c63460528978c0cc3a268a1385a6dcbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310971 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/main@{#948488}
Bug: b/208815006 Change-Id: If72f6cfd0eaa561dda6e7e5e8a8409e3737ece70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314561 Commit-Queue: Norge Vizcay <vizcay@google.com> Reviewed-by: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/main@{#948489}
- Remove js_type_check/js_library targets (remaining type coverage will be re-added in follow-up CLs) - Check-in TypeScript definitions for fuse.js - Migrate all non-UI files to TypeScript. - Remove unnecessary constructor param for BiMap (was only used in tests). UI files will be migrated in follow-up CLs. Bug: 1260300 Change-Id: I6f71e940f4ed4e18eb6c8a174f43f2cccf29c8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312883 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/main@{#948490}
Disable MediaEngagementScoreWithOverrideFieldTrialsTest.
OverrideFieldTrial
Bug: 1276910
Change-Id: Iab24146e67f6263af52cc62f83dac91fda8637f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317344
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Owners-Override: Rainhard Findling <rainhard@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#948491}
Bug: 1276915 Change-Id: Icaab5edd480d6572c82ec6e4a3504f219d190603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314832 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Owners-Override: Rainhard Findling <rainhard@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/main@{#948492}
This CL fixes the #defines across the codebase to properly reflect that Lacros uses Mirror and not Dice. A lot of Dice-specific code is excluded from Lacros build, and in particular all the code related to chrome://welcome screen. This CL should not change the behavior and is only a refactoring. Fixed: 1198523 Change-Id: I8957e97441849a53ff3848cbc9aad4374d4f4b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314556 Reviewed-by: Jan Krčál <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/main@{#948493}
Bug: b:200678974 Change-Id: I9e3c4c8b7b43afcd80ca40e93541845b26d050ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306575 Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/main@{#948494}
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ed0048904ef1..440d06ad1a21 2021-12-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com Change-Id: I35971f342bc4e3ed53215efafa9a4576edfa23e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317458 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948495}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: I4ea8d705b52d084e82c81f74e85e1879dc20d5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317362 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948496}
https://chromium.googlesource.com/angle/angle.git/+log/10e5f34d1439..60e457b8badc 2021-12-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9970c397e55e to 5b3be708ab2f (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ieab9cdfeb05caefb3a0a01fe8551758f4c05452a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317459 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948497}
Disable ChromePasswordProtectionServiceTest. VerifyUserPopulationForSyncPasswordEntryPing. Bug: 1276906 Change-Id: I304e172af68c43e5a8e57988ce656a55e3abe8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314908 Owners-Override: Rainhard Findling <rainhard@chromium.org> Auto-Submit: Rainhard Findling <rainhard@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/main@{#948498}
Bug: none Change-Id: I3d29021658d1c6d3a4eef2d44a1e6c9cdd148e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310923 Reviewed-by: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Johan Bay <jobay@chromium.org> Cr-Commit-Position: refs/heads/main@{#948499}
Clusterfuzz found a rare scenario where we call the Page#getResourceTree CDP method on a frame that has no DocumentLoader associated. This causes a nullptr dereference in the current implementation. This CL fixes that by being more defensive. R=alexrudenko@chromium.org, caseq@chromium.org Fixed: 1270184 Change-Id: I73cc6b5ea6dd4984ae3ae8c0f3adb42a65cae160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307447 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#948500}
…on ash." This reverts commit 772e59f. Reason for revert: crbug.com/1276911 Original change's description: > Web apps: Use dark mode theme color and background color in non ash. > > This uses NativeTheme ShouldUseDarkColors() instead of > ash::ColorProvider IsDarkModeEnabled(). > > Bug: 1271804 > Change-Id: I8834bd5dce94da1e8aa359ad46c1a3909e579676 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314460 > Commit-Queue: Louise Brett <loubrett@google.com> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/main@{#948454} Bug: 1271804, 1276911 Change-Id: I2187575d88ad6ea80679f17d56cc520e0b1a1d88 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317426 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Owners-Override: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/main@{#948501}
This CL pays some technical debt in tests by resolving a TODO. Bug: 1200034 Change-Id: I20a93f236cfecdb067486018b8de80940d60b1c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314557 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#948502}
This reverts commit 84c61e3. Reason for revert: crbug.com/1276949 Original change's description: > [ash] take capture during webui tab drag > > The web ui tabstrip requires a capture to drag correctly in ash chrome, > where there is no toplevel drag handler created. I observed that a > longpress/gesture start events on the tab items would not start the > drag reaction in the tabstrip if the target was not changed from the > tab container. Not exactly sure, but to remove capture we might need > to revise how the tabstrip responds to gestures. > > To avoid duplicating this code, move the capture/drag_tracker management > into a new class that is shared by the tab_drag_drop_delegate and the > extended_drag_source classes. > > Bug: 1270492 > Change-Id: I486219301126035fce85d29a2b8666ec62d95d4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307416 > Commit-Queue: Jonah Williams <jonahwilliams@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/main@{#947392} Bug: 1270492, 1276949 Change-Id: I781d2a8f95ceb2a510db59aa3ff6728a644ac8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317423 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Owners-Override: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/main@{#948504}
This CL makes sure the WebBluetoothGetDevices and WebBluetoothWatchAdvertisements blink runtime features are enabled when WebBluetoothNewPermissionsBackend is enabled. That way, users who want to experiment with Bluetooth.getDevices() or BluetoothDevice.watchAdvertisements() only have to enable the WebBluetoothNewPermissionsBackend flag, not the dangerous kEnableExperimentalWebPlatformFeatures flag. Change-Id: Ibf5f71bdb1160c2428e7881fe08f5eb7b9e4f03c Bug: 589228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309640 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#948505}
https://android.googlesource.com/platform/external/perfetto.git/+log/e9e81c015296..c949b5f8e83d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I314968ab9de74d72ccc2b6a611f810e2e4516e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3316979 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948506}
Bug: b:204748009 Test: manually Change-Id: I9b6b0ccb161f2fbfcfd149893d1576d15f35b269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314637 Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Reviewed-by: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/main@{#948507}
Apple fixed this issue on iOS 15. We can clean this method when we drop iOS 14. Bug: 2726241 Change-Id: I28f4a40efffe361d4749d11d4d6085e20498a338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314912 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/main@{#948508}
https://android.googlesource.com/platform/external/perfetto.git/+log/c949b5f8e83d..b54e61f0f244 2021-12-06 hjd@google.com ui: Fix tooltip rendering If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:208839043 Tbr: perfetto-bugs@google.com Change-Id: I23e2513fb5bb64d368315541904e12cf0e57b8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317466 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948509}
The test, ActiveUserNotOwner, is flakily crashing due to adding a user and not removing it. This CL remove the unnecessary UserManager::AddUser call. The root cause is related to b/208629291. Bug: b:203402916, 1275488 Test: browser_tests --gtest_filter="*ActiveUserNotOwner*" --gtest_repeat=1000 Change-Id: Icd172faae705570e7b3abac2fb1e5d0eaa5503ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3311293 Commit-Queue: Mahmoud Gawad <mgawad@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Auto-Submit: Mahmoud Gawad <mgawad@google.com> Reviewed-by: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/main@{#948510}
Bug: 1275617 Change-Id: I016ed570cda8ecb15fd6c4b747f965967e30564f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3311023 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Tony Herre <toprice@chromium.org> Cr-Commit-Position: refs/heads/main@{#948511}
Change-Id: Ie9737c975ae73b61d9daf12b5fdd70c5a5024bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317422 Reviewed-by: Maria Kazinova <kazinova@google.com> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/main@{#948512}
https://dawn.googlesource.com/dawn.git/+log/3a464767a530..13d6af93fbf5 2021-12-06 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 10e5f34d1439 to 60e457b8badc (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I481601088be4958a88f72aa7f24a99a5447ca425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317468 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948513}
https://chromium-review.googlesource.com/c/chromium/src/+/3298858 added early PartitionAlloc initialization to Chromium's main app, but didn't add it to content_shell. From early field data, the CL linked to above seems to have solved the issues, so extend early initialization to content_shell. Bug: 1272149 Change-Id: Ic82f3f261034b3f7c6fb1383e11169ca354fd6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314829 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#948514}
This reverts commit 0edab9f. The original CL was reverted as it broke linux-chrome due to a ListValue::GetBoolean() call site that was previously missed as it is only compiled with certain build flags. The diff from the original CL is to fix this remaining call site. Original description: Now that all ListValue::GetBoolean() call sites have been removed, the function itself can finally be removed as well. Bug: 1187086 Change-Id: I03a1a399cedc31594e229a38b4b824154481b47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312931 Auto-Submit: Nidhi Jaju <nidhijaju@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org> Cr-Commit-Position: refs/heads/main@{#948515}
Allows modifying leak detection toggle by signed out users. This is currently hidden by a feature flag. Keeps the same string logic: * signed out users with feature enabled (http://screen/AynPMn6LgHvJtvt) * signed out users with feature disabled (http://screen/6Z6fxTEJuuPqYio) Bug: 1261835 Change-Id: I0c89adf84f78b5d782c3e421284405e04266502d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313002 Commit-Queue: Rafał Godlewski <rgod@google.com> Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/main@{#948516}
https://android.googlesource.com/platform/external/perfetto.git/+log/e9e81c015296..c949b5f8e83d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibc2b345096da5aa76aefd4b2c69d5825f097bbd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3316980 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948517}
Roll Chrome Linux PGO profile from chrome-linux-main-1638770344-d93018a1e2151f8cfe43f76501c02f3069ab2c34.profdata to chrome-linux-main-1638791758-710584749cfa00b31ebd36c723626f0698441c55.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I164ffcaa122dfab946c4243ba0aae0c81be4fc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317559 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948518}
Roll Chrome Win64 PGO profile from chrome-win64-main-1638780863-ad3a47555d8a1a75d7fa6dc0ecdcde3a1c0abe82.profdata to chrome-win64-main-1638791758-eb339a4119ba192eb551d5cc7bcb131e21125867.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7cb6df030075e720db7f6c2da5ebaecb4c63327a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317470 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948519}
Change-Id: I995ee64e286825eea8839217ce59fa08936cdb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315459 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948520}
Roll Chrome Win32 PGO profile from chrome-win32-main-1638770344-40f9a255708f8198ddcfdaa19d2b66fecaf16a3b.profdata to chrome-win32-main-1638791758-561d0fec5a5cacff96c1736bc4540eac4b089d35.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3a0fb9b98f544df5d3636d30f5e873aed0fe0996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317471 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948521}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4745e98f..c62f8590 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iede850a276923886c3d160ee9287bac15595782b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317298 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948522}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7565b27cbf4b..0980f52facf7 2021-12-06 bmeurer@chromium.org [elements] Improve ergonomics of Properties pane. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I312331b74f9ce8dde8f7e6f84195d4d8d5b9194e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317469 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948523}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I92a4fd1ff44fd7a8246b40d5defdf071d9896036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317467 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948524}
UNLIKELY() is added on all PCScan paths but one, add it where it's missing. This turns this code: 0x000000000120e1f9 <+169>: cmp $0x2,%r12b 0x000000000120e1fd <+173>: jne 0x120e211 <base::internal::PartitionMalloc(base::allocator::AllocatorDispatch const*, unsigned long, void*)+193> ===== START OF REMOVED CODE ===== 0x000000000120e1ff <+175>: mov 0x334ad2(%rip),%rax # 0x1542cd8 0x000000000120e206 <+182>: mov 0x39(%rax),%al 0x000000000120e209 <+185>: test $0x1,%al 0x000000000120e20b <+187>: jne 0x120e54b <base::internal::PartitionMalloc(base::allocator::AllocatorDispatch const*, unsigned long, void*)+1019> ===== END OF REMOVED CODE ====== 0x000000000120e211 <+193>: cmpb $0x0,0x2(%r14) 0x000000000120e216 <+198>: mov %r14,-0x38(%rbp) 0x000000000120e21a <+202>: je 0x120e311 <base::internal::PartitionMalloc(base::allocator::AllocatorDispatch const*, unsigned long, void*)+449> into this one: 0x000000000120e3b9 <+169>: cmp $0x2,%r12b 0x000000000120e3bd <+173>: je 0x120e573 <base::internal::PartitionMalloc(base::allocator::AllocatorDispatch const*, unsigned long, void*)+611> 0x000000000120e3c3 <+179>: cmpb $0x0,0x2(%r14) 0x000000000120e3c8 <+184>: mov %r14,-0x38(%rbp) 0x000000000120e3cc <+188>: je 0x120e4c3 <base::internal::PartitionMalloc(base::allocator::AllocatorDispatch const*, unsigned long, void*)+435> And the fast path ret instruction from +448 to +434. Bug: 998048 Change-Id: I31f64ba254848d9c65e6ef8e30ad77562b3bc313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317421 Commit-Queue: Benoit Lize <lizeb@chromium.org> Reviewed-by: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/main@{#948525}
Change-Id: Ifde9d99b1d0c33b8cf29553ca66253594cf819bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3316601 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/main@{#948526}
Bug: b:197615068 Change-Id: Ie6526f476e317394f3d0c77f7b784627b7a6c427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306732 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/main@{#948527}
When a tab is captured, a blue border indicates which tab is being captured. Previously, the code misbehaved for multiple concurrent captures of the same tab. Issues: * Only the last capture had a blue border. * If a tab was captured multiple times, stopping one of the captures removed the border, despite ongoing other captures of the tab. This CL fixes these issues. Bug: 1270249, 1276822 Change-Id: Iadf47c91d20d7b43bef9c5accf3c85ec1d817962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314905 Commit-Queue: Elad Alon <eladalon@chromium.org> Auto-Submit: Elad Alon <eladalon@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/main@{#948528}
This CL notifies the FullscreenController of a lock state change. If required, the FullscreenController could then show the full screen notification. (We currently still exit full screen mode before locking a session. This will be changed in a following CL.) Bug: b:203501653 Change-Id: Ib8d622853a068223671fcb754df7cd1743e91e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3284926 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/main@{#948529}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/rts-windows-amd64-chromium-autoroll Please CC guterman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: guterman@google.com Change-Id: I7b68ac36a3cc7c2faed06fd2ae5048074fae1a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317566 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#948530}
Change-Id: I6e26a0914d9e2cb2b98f8ac6c183b8382fdcb338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3316197 Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: Nan Lin <linnan@chromium.org> Cr-Commit-Position: refs/heads/main@{#948531}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )