Replace ToReadOnlyCollection with AsReadOnlyList #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The semantics of ToReadOnlyCollection were confusing to many developers, as it doesn't guarantee that the underlying collection can't be mutated. (It was an "antipattern" to use it in a constructor and store the returned value in a field.) The new AsReadOnlyList method provides the same efficiency, with a name that implies it's just a view, not a conversion.
ejball
approved these changes
Sep 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantics of
ToReadOnlyCollectionwere confusing to many developers, as it doesn't guarantee that the underlying collection can't be mutated. (It was an "antipattern" to use it in a constructor and store the returned value in a field.)The new
AsReadOnlyListmethod provides the same efficiency, with a name that implies it's just a view, not a conversion.Most callers of
ToReadOnlyCollectionshould just switch toAsReadOnlyList; constructors should explicitly call.ToList().AsReadOnly()(or.ToList().AsReadOnlyList()) to make a private copy of a collection supplied via a constructor argument.