Unexpected Behaviour with Parameterized Properties

[flandersen]

This fails but it shouldn't:
I configured an object to be returned if the parameterized property is called with "Width". When you then call the property with another string you get another fake. That's ok. But if you call the property with "Width" again you don't get the correct fake, see VB.Net code below.

This behaviour doesn't appear when you change the property into a function.

Public Interface IHmiProperties

    Property Properties(name As String) As IHmiProperty
End Interface

Public Interface IHmiProperty

    Property Name As String
End Interface

<TestMethod>
Public Sub PropertiesWithStringParameter_ShouldntFailIfPropertyNotConfigured()
    ' Arange
    Dim widthProperty As IHmiProperty = A.Fake(Of IHmiProperty)()
    widthProperty.Name = "Width"

    Dim properties As IHmiProperties = A.Fake(Of IHmiProperties)()
    A.CallTo(Function() properties.Properties("Width")).Returns(widthProperty)

    ' Act
    properties.Properties("SomeOther").Name = "Dummy"

    ' Assert
    Assert.AreEqual("Width", properties.Properties("Width").Name)
End Sub

[blairconrad]

@flandersen, thanks for mentioning this. I wonder if it's not the same underlying problem as in #277.
If you're interested, I have a workaround posted in the StackOverflow question that begat that issue. Perhaps give it a try and see if it eases your pain while we investigate?

[blairconrad]

Putting in the Backlog and marking as P2 for now.

[flandersen]

@blairconrad, thanks for your quick reply. Your workaround seems to work quite well. But I had to write A(Of String).Ignored because VB.Net doesn't allow me to use the shortcut A(Of String)._.

<TestMethod>
Public Sub PropertiesWithStringParameter_ShouldntFailIfPropertyNotConfigured()
    ' Arange
    Dim widthProperty As IHmiProperty = A.Fake(Of IHmiProperty)()
    widthProperty.Name = "Width"

    Dim properties As IHmiProperties = A.Fake(Of IHmiProperties)()
    '' TODO: Delete when bug is fixed https://github.com/FakeItEasy/FakeItEasy/issues/293
    A.CallTo(Function() faceplateTypical.Properties(A(Of String).Ignored)).ReturnsLazily(Function() A.Fake(Of IHmiProperty)())
    ''

    A.CallTo(Function() properties.Properties("Width")).Returns(widthProperty)

    ' Act
    properties.Properties("SomeOther").Name = "Dummy"

    ' Assert
    Assert.AreEqual("Width", properties.Properties("Width").Name)
End Sub

[blairconrad]

I'm glad to hear you have some relief. Of course, I still think we have an opportunity to improve the FakeItEasy indexed property handling.

[blairconrad]

Marking as 2 - Working and enhancement (a closer look makes me think that indexed property support was never implemented, not that there's a flaw in the implementation) and assigning to me.

[blairconrad]

@flandersen, thanks very much for raising this issue. Look for your name in the release notes. 🏆

This issue has been fixed in release 1.21.0.

https://www.nuget.org/packages/FakeItEasy/1.21.0
https://github.com/FakeItEasy/FakeItEasy/releases/tag/1.21.0

[flandersen]

Thanks Blair for the fix. Works great.

Am 28.05.2014 um 11:55 schrieb Blair Conrad notifications@github.com:

@flandersen, thanks very much for raising this issue. Look for your name in the release notes.

This issue has been fixed in release 1.21.0.
@flandersen, thanks very much for raising this issue. Look for your name in the release notes.

This issue has been fixed in release 1.21.0.

https://www.nuget.org/packages/FakeItEasy/1.21.0
https://github.com/FakeItEasy/FakeItEasy/releases/tag/1.21.0

—
Reply to this email directly or view it on GitHub.

[blairconrad]

Yay. I'm glad!