Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Lazy version of AssignOutAndRefParameters #319

Closed
blairconrad opened this issue May 30, 2014 · 6 comments
Closed

Provide a Lazy version of AssignOutAndRefParameters #319

blairconrad opened this issue May 30, 2014 · 6 comments

Comments

@blairconrad
Copy link
Member

From FakeItEasy AssignsOutAndRefParameters - lazily?:

I'm trying to fake a call to a method with an out parameter, with a ReturnsLazily with some basic logic in it. Ideally, I could assign a value via AssignsOutAndRefParameters based on the ReturnsLazily. However, AssignsOutAndRefParameters only accepts a value up front when the expression is compiled, is there any 'Lazily' type behavior that I'm missing?

@crutt
Copy link

crutt commented May 31, 2014

Started working on this in a fork/branch. I have an initial version in place but haven't had a chance to test yet. If you have time for a quick look that would be great, I'm questioning how receptive y'all may be to the change to OutAndRefParametersValues.

@blairconrad
Copy link
Member Author

Thanks for the work, @crutt! I've been busy today but will try to give it a look tomorrow or early Monday.

crutt pushed a commit to crutt/FakeItEasyCrutt that referenced this issue Jun 1, 2014
@crutt
Copy link

crutt commented Jun 1, 2014

No problem @blairconrad, happy to help. I found a little time tonight as well and added tests where they seemed appropriate, and cleaned up a few minor style issues. Glad the rake setup is as painless as advertised. 😄

crutt pushed a commit to crutt/FakeItEasyCrutt that referenced this issue Jun 3, 2014
Clean up comments, tests, parameters, and warnings associated with the
work done on AssignOutAndRefParametersLazily
@blairconrad
Copy link
Member Author

@crutt, I've merged #320.

Are you interested in working on the "convenience" methods like ReturnsLazily has?

I think it's a good addition, so I made #322 anyhow. Chat there if want it!

@blairconrad
Copy link
Member Author

Closed by #320.

@blairconrad blairconrad added this to the 1.22.0 milestone Jun 7, 2014
@blairconrad
Copy link
Member Author

@crutt, thanks very much for your work on this issue. Look for your name in the release notes. 🏆

This issue has been fixed in release 1.22.0.

https://www.nuget.org/packages/FakeItEasy/1.22.0
https://github.com/FakeItEasy/FakeItEasy/releases/tag/1.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants