Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IFakeAndDummyManager properties, not fields #1054

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Make IFakeAndDummyManager properties, not fields #1054

merged 1 commit into from
Apr 17, 2017

Conversation

blairconrad
Copy link
Member

Supports #769. Fixes a bug I introduced in #1052.

@blairconrad
Make IFakeAndDummyManager properties, not fields
2fee221 
When they're static fields, the IFakeAndDummyManager instances can be
initialized before their dependencies are available, causing an error, which
will be cached and prefent proper operation in the future.
This can happen especially when a Dummy factory or options builder
uses the A or Fake<T> classes.
@thomaslevesque thomaslevesque merged commit e639bdb into FakeItEasy:master Apr 17, 2017
@thomaslevesque
Copy link
Member

Thanks for the quick fix @blairconrad!

@blairconrad
Copy link
Member Author

Thank you, @thomaslevesque.

@blairconrad blairconrad added this to the 3.3.0 milestone Apr 17, 2017
@blairconrad blairconrad deleted the fix-static-initialization branch April 17, 2017 17:09
@blairconrad
Copy link
Member Author

This issue was fixed in Release 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaslevesque thomaslevesque thomaslevesque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blairconrad @thomaslevesque