Add an assembly targeting .NET 4.5 #1108
Conversation
| { | ||
| Approvals.Verify(PublicApiGenerator.GetPublicApi(typeof(A).Assembly)); | ||
| ApproveApi("net45"); |
There was a problem hiding this comment.
I know, it's a little less efficient than just using the assembly that's in memory. I can revert, if you like.
There was a problem hiding this comment.
No, it's fine; it's better to do it the same way for all assemblies, when possible. But the project reference to FakeItEasy should be removed from this project, since it's no longer necessary.
| <!-- .NET 4.5 --> | ||
|
|
||
| <PropertyGroup Condition="'$(TargetFramework)' == 'net45'"> | ||
| <DefineConstants>$(DefineConstants);FEATURE_BINARY_SERIALIZATION;FEATURE_REFLECTION_GETASSEMBLIES;FEATURE_SELF_INITIALIZED_FAKES</DefineConstants> |
There was a problem hiding this comment.
note the lack of FEATURE_EVENT_ARGS_MUST_EXTEND_EVENTARGS
There was a problem hiding this comment.
Thanks @blairconrad. Looks good to me, just one minor comment.
| { | ||
| Approvals.Verify(PublicApiGenerator.GetPublicApi(typeof(A).Assembly)); | ||
| ApproveApi("net45"); |
There was a problem hiding this comment.
No, it's fine; it's better to do it the same way for all assemblies, when possible. But the project reference to FakeItEasy should be removed from this project, since it's no longer necessary.
|
It was a good comment. I've removed the reference and the superfluous "content" entries from the csproj. |
|
Thanks, @blairconrad 👍 |
Fixes #1008.
I know we're a little concerned about the lack of testing for the .NET 4.0 assembly, and how having both 4.0 and 4.5 may lead to extra maintenance, but there's nothing preventing us from removing 4.0 support in the future.