Detect wrong-typed constraints #1246
Conversation
There was a problem hiding this comment.
Very nice, @thomaslevesque. I did make a couple of minor comments. If you agree and implement the suggested changes, feel free to squash/amend as you go.
| @@ -20,4 +22,9 @@ internal interface IArgumentConstraint | |||
| /// <returns>True if the argument is valid.</returns> | |||
| bool IsValid(object argument); | |||
| } | |||
|
|
|||
| internal interface ITypedArgumentConstraint : IArgumentConstraint | |||
There was a problem hiding this comment.
Should be in a separate file, no?
| "Then the call configuration throws a FakeConfigurationException" | ||
| .x(() => exception.Should().BeAnExceptionOfType<FakeConfigurationException>()); | ||
|
|
||
| "And the message should indicate the actual and expected type" |
There was a problem hiding this comment.
nit: previous steps used the imperative mood, not the subjunctive (fun fact: I would probably not even know these moods exist were it not for learning about "le subjontif" in school).
Consider rewording. Maybe something like "And the message indicates the actual and expected types"
(oh, I changed "type" to "types" there as well)
| } | ||
|
|
||
| [Scenario] | ||
| public static void PassingHiddenConstraintWithWrongTypeToAMethod( |
thomaslevesque
force-pushed
the
detect-wrong-type-constraint
branch
2 times, most recently
from
d472eea
to
be30855
Compare
thomaslevesque
force-pushed
the
detect-wrong-type-constraint
branch
from
be30855
to
bf8d8c2
Compare
|
The rebase was a bit messy, hopefully I didn't break anything... |
|
Nice, @thomaslevesque! Thanks. |
|
Thanks for the merge! |
Fixes #1237
The 3rd commit is a simplification. I realized that only
MatchesConstraintcould be created by the argument constraint trap, so we don't need to introduce aTypeproperty for other types of constraint.