Use StyleCop.Analyzers 1.1.0-beta006 #1304
Conversation
| @@ -13,5 +13,6 @@ | |||
| <Rule Id="CA1824" Action="None" /> | |||
| <Rule Id="CA2201" Action="None" /> | |||
| <Rule Id="CA2210" Action="None" /> | |||
| <Rule Id="SA0001" Action="None" /> | |||
There was a problem hiding this comment.
1.1.0-beta006 doesn't like it when a project is set to not generate XML docs. We don't really need them for the Examples or Tests.
| methodOrIndexerName = indexer.Name; | ||
| parameters = indexer.Parameters; | ||
| return true; | ||
| } |
There was a problem hiding this comment.
The analyzer noticed that a few files had inconsistent indentation.
| @@ -11,6 +11,7 @@ | |||
| <Rule Id="SA1124" Action="Warning" /> | |||
| <Rule Id="SA1127" Action="None" /> | |||
| <Rule Id="SA1128" Action="None" /> | |||
| <Rule Id="SA1413" Action="None" /> | |||
There was a problem hiding this comment.
The analyzer prefers a trailing comma in multiline initializers. I do too, but there are many instances where we don't use one, and I wasn't sure of the prevailing sentiment. I'm happy to remove this and add the commas…
There was a problem hiding this comment.
I usually don't add a trailing comma, but I don't care if there is. Suppressing the warning is fine, as far as I'm concerned.
|
Thanks @blairconrad! |
|
Thanks, @thomaslevesque! |
|
This change has been released as part of FakeItEasy 4.4.0. |
I wanted to use a
!with pattern matching as part of my work on #1297.StyleCop.Analyzers couldn't handle it, thinking that
had too many parentheses. I noticed the bug was fixed in 1.1.0-beta006, so thought, "why not upgrade?".