Drop MSBuild, use dotnet build instead

[thomaslevesque]

As discussed with @adamralph, not sure where/when it was.
We no longer need to call MSBuild explicitly, so we don't need VSWhere anymore.

[blairconrad]

It's beautiful, @thomaslevesque. Thanks.

Confession time: I didn't completely follow when last we talked about the build prerequisites. It seems that we now don't need VS or MSBuild, but you were concerned about some other extensions or plugins or something that I don't know what they are. Are you happy with how_to_build.md as it is?

[thomaslevesque]

It seems that we now don't need VS or MSBuild

I think we don't. But I'd like to check, first. I'll create a clean VM in Azure to make sure.

but you were concerned about some other extensions or plugins or something that I don't know what they are.

I don't remember what it might be.

Are you happy with how_to_build.md as it is?

No, I should update it. We might want to state clearly that it only works on Windows (because of ILMerge). It was implied by the VS requirement, but if that requirement is gone we should be more explicit. Currently it's a little understated:

At the time of writing the build is only confirmed to work on Windows using the Microsoft .NET framework.

[adamralph]

Looks great!

[thomaslevesque]

I think we don't. But I'd like to check, first. I'll create a clean VM in Azure to make sure.

OK, so Visual Studio itself isn't required, but we still need

• .NET 4.6.1 Developer Pack (available from this page)
• .NET 4.5 Developer Pack (NOT available as a standalone download, can be installed as part of the Visual Studio Build Tools, available from this page, in the "Tools for Visual Studio 2017 section)

So I think the easiest way to describe the requirements is to say that we need VS2017 or at least the VS Build Tools.

[thomaslevesque]

I think this is implied by VS2017 (you can't have VS2017 without having net461 or later)

[blairconrad]

I do love me some deleted lines. Thanks, @thomaslevesque!

[thomaslevesque]

Thanks for the merge!

[blairconrad]

This change has been released as part of FakeItEasy 4.9.0.