-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links to use https in README.md #1459
Conversation
I like it, @thomaslevesque. But I wonder if while we're at it, we shouldn't update the other https…
We can make this another issue, if you prefer. |
Good point. I'll do it. |
23ce482
to
3fe2d4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, done. There are 3 links that don't support HTTPS:
@@ -1,4 +1,4 @@ | |||
<!-- NOTE (adamralph): For more info see: http://msdn.microsoft.com/en-us/library/bb514188.aspx --> | |||
<!-- NOTE (adamralph): For more info see: https://docs.microsoft.com/en-us/visualstudio/code-quality/how-to-customize-the-code-analysis-dictionary --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link redirects there, so I put the new URL
3fe2d4d
to
ca26e5d
Compare
@@ -6,9 +6,7 @@ namespace FakeItEasy | |||
|
|||
/// <summary> | |||
/// Hides standard Object members to make fluent interfaces | |||
/// easier to read. Found in the source of Autofac: <see cref="!:http://code.google.com/p/autofac/"/> | |||
/// Based on blog post here: | |||
/// <see cref="!:http://www.clariusconsulting.net/blogs/kzu/archive/2008/03/10/58301.aspx"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link is broken, and I couldn't find another article explaining this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh! Your Google-fu is better than mine. Still no HTTPS, though. I'll amend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your Google-fu is better than mine
Today, perhaps.
ca26e5d
to
00d739d
Compare
Thanks, @thomaslevesque! |
Thanks for the merge! |
This change has been released as part of FakeItEasy 4.9.1. |
I noticed that the Markdown preview in VSCode didn't load the FakeItEasy logo because it was a non secure URL. So while I was at it, I updated all links to use https. (except sourcebrowser.io, which doesn't support https)