Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Bullseye 2.1.0 beta 1 #1471

Merged
merged 1 commit into from
Oct 8, 2018
Merged

switch to Bullseye 2.1.0 beta 1 #1471

merged 1 commit into from
Oct 8, 2018

Conversation

adamralph
Copy link
Contributor

@adamralph adamralph commented Oct 7, 2018

Looking for feedback on this version. The main change is that a specific colour palette is chosen depending on which CI system is detected. Currently Appveyor, Travis CI, and TeamCity are supported.

For reference, this is how the output looks in a local console:

And these are the console colours available on Appveyor:

Before

After

@thomaslevesque
Copy link
Member

I'm colorblind, so it doesn't really make a big difference to me... @blairconrad might have a more useful opinion 😉

@adamralph
Copy link
Contributor Author

@thomaslevesque your feedback could still be very useful. E.g. do you find there is enough contrast between the background and the "Bullseye/{target}" labels in the "After" snippet for you to read them? And how does that compare with the "Before" snippet?

I'm not wild about the colour choice for those labels, but the Appveyor palette didn't give me any better option, other than sticking with the old choice, and losing the distinction between the target names and the input values.

@thomaslevesque
Copy link
Member

E.g. do you find there is enough contrast between the background and the "Bullseye/{target}" labels in the "After" snippet for you to read them? And how does that compare with the "Before" snippet?

There's enough contrast for me to be able to read everything, both before and after. But a closer look made me realize that some things appeared to be the same color before (e.g. targets and their "sub-targets") and are now different. So I guess it's a change for the better.

@adamralph adamralph mentioned this pull request Oct 8, 2018
11 tasks
@blairconrad
Copy link
Member

I'm not wild about the colour choice for those labels, but the Appveyor palette didn't give me any better option, other than sticking with the old choice, and losing the distinction between the target names and the input values.

I agree. Well, mostly I don't like how the blue background limits your options for attractive, high-contrast labels.
I had never considered that there was a need for a distinction between the target names and the input values, but I can see the value.

There's enough contrast for me to be able to read everything, both before and after. But a closer look made me realize that some things appeared to be the same color before (e.g. targets and their "sub-targets") and are now different. So I guess it's a change for the better.

Yup. Me too.

@blairconrad blairconrad merged commit 1308257 into FakeItEasy:develop Oct 8, 2018
@blairconrad blairconrad added this to the vNext milestone Oct 8, 2018
@adamralph adamralph deleted the bullseye-beta branch October 8, 2018 16:49
@adamralph
Copy link
Contributor Author

👍 thanks for the feedback.

@thomaslevesque
Copy link
Member

This change has been released in FakeItEasy 5.0.0.
Thanks @adamralph!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants