-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to Bullseye 2.1.0 beta 1 #1471
Conversation
I'm colorblind, so it doesn't really make a big difference to me... @blairconrad might have a more useful opinion 😉 |
@thomaslevesque your feedback could still be very useful. E.g. do you find there is enough contrast between the background and the "Bullseye/{target}" labels in the "After" snippet for you to read them? And how does that compare with the "Before" snippet? I'm not wild about the colour choice for those labels, but the Appveyor palette didn't give me any better option, other than sticking with the old choice, and losing the distinction between the target names and the input values. |
There's enough contrast for me to be able to read everything, both before and after. But a closer look made me realize that some things appeared to be the same color before (e.g. targets and their "sub-targets") and are now different. So I guess it's a change for the better. |
I agree. Well, mostly I don't like how the blue background limits your options for attractive, high-contrast labels.
Yup. Me too. |
👍 thanks for the feedback. |
This change has been released in FakeItEasy 5.0.0. |
Looking for feedback on this version. The main change is that a specific colour palette is chosen depending on which CI system is detected. Currently Appveyor, Travis CI, and TeamCity are supported.
For reference, this is how the output looks in a local console:
And these are the console colours available on Appveyor:
Before
After