Move most proxy generator tests to specs #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaslevesque
requested changes
Nov 16, 2018
There was a problem hiding this comment.
Thanks @blairconrad! I made a cursory review and found just one issue.
| using FluentAssertions; | ||
| using Xbehave; | ||
| using Xunit; | ||
|
|
||
| public static class FakingDelegates | ||
| { | ||
| public delegate void VoidDelegateWithOutAndRefValues(out string outString, ref int refInt); | ||
|
|
||
| public delegate void NonVoidDelegateWithOutAndRefValues(ref string refString, out int outInt); |
There was a problem hiding this comment.
Shouldn't this delegate return something, given its name?
blairconrad
force-pushed
the
tests-to-specs
branch
from
74c34f3
to
973a541
Compare
|
Thanks, @thomaslevesque. One more issue than I found! Hey! I never noticed the force-pushed note before:
|
I never noticed it either. I think it's new! |
thomaslevesque
approved these changes
Nov 16, 2018
|
Thank you, @thomaslevesque. |
|
This change has been released in FakeItEasy 5.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were very low-level, and I've some upcoming PRs that will needlessly break them.