Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using Zip to check argument constraints #1507

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Stop using Zip to check argument constraints #1507

merged 1 commit into from
Nov 29, 2018

Conversation

blairconrad
Copy link
Member

Method Job Mean Error StdDev Ratio RatioSD Gen 0/1k Op Gen 1/1k Op Gen 2/1k Op Allocated Memory/Op
Verify 4.10.0-alpha094 22.444 us 0.2249 us 0.2104 us 1.00 0.00 1.8500 0.0200 0.0100 5.83 KB
Verify 4.10.0-optimize-verify001 21.444 us 0.2543 us 0.2379 us 0.96 0.02 1.8200 0.0200 0.0100 5.73 KB
VerifyOnly 4.10.0-alpha094 6.459 us 0.1397 us 0.1307 us 1.00 0.00 0.6400 - - 1.99 KB
VerifyOnly 4.10.0-optimize-verify001 5.934 us 0.2179 us 0.2039 us 0.92 0.05 0.6100 - - 1.9 KB

image

thomaslevesque
thomaslevesque approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@thomaslevesque thomaslevesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @blairconrad!

@thomaslevesque thomaslevesque merged commit 748ab7a into FakeItEasy:develop Nov 29, 2018
@blairconrad blairconrad added this to the vNext milestone Nov 29, 2018
@blairconrad
Copy link
Member Author

Thank you, sir!

@blairconrad blairconrad deleted the optimize-verify branch November 29, 2018 10:50
@thomaslevesque
Copy link
Member

This change has been released in FakeItEasy 5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaslevesque thomaslevesque thomaslevesque approved these changes

Assignees
No one assigned
Labels
💨 performance 🚀 enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blairconrad @thomaslevesque