Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore nupkgs to artifacts/output #1523

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

blairconrad
Copy link
Member

Connects to #1520.

@blairconrad
Copy link
Member Author

blairconrad commented Dec 4, 2018

Currently they're being placed under their project build areas and are not published to the AppVeyor feed.

@adamralph
Copy link
Contributor

Oops, sorry about that.

Personally I would remove that option altogether and let the packages go to the default location. They can be swept up into artifacts on Appveyor like so: https://github.com/adamralph/bullseye/blob/5b1c3d84be5c7daf8cbddb2ee8c164d629b67947/appveyor.yml#L19

Copy link
Member

@thomaslevesque thomaslevesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomaslevesque
Copy link
Member

Personally I would remove that option altogether and let the packages go to the default location

I think I prefer to have them all in the same place. @blairconrad, what do you think?

@blairconrad
Copy link
Member Author

blairconrad commented Dec 4, 2018

I prefer them in one place. They're easier for computers and humans to find. While AppVeyor can be configured to sweep them up, and so can FakeItEasy's "sweep up artifacts on build failure" script, having them all appear under artifacts/outputs makes another behaviour better: I only have to configure one custom NuGet source directory and I can consume all my locally-built FakeItEasy* nupkgs.

@blairconrad
Copy link
Member Author

Oops, sorry about that.

It's all good. No harm done, and all three of us failed to notice the change in behaviour.

@thomaslevesque thomaslevesque merged commit e26cef4 into FakeItEasy:develop Dec 4, 2018
@thomaslevesque
Copy link
Member

Thanks @blairconrad

@blairconrad blairconrad deleted the fix-nupkg-output branch December 4, 2018 15:23
@blairconrad blairconrad added this to the vNext milestone Dec 10, 2018
@thomaslevesque
Copy link
Member

This change has been released in FakeItEasy 5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants