-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore nupkgs to artifacts/output #1523
Restore nupkgs to artifacts/output #1523
Conversation
Currently they're being placed under their project build areas and are not published to the AppVeyor feed. |
Oops, sorry about that. Personally I would remove that option altogether and let the packages go to the default location. They can be swept up into artifacts on Appveyor like so: https://github.com/adamralph/bullseye/blob/5b1c3d84be5c7daf8cbddb2ee8c164d629b67947/appveyor.yml#L19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think I prefer to have them all in the same place. @blairconrad, what do you think? |
I prefer them in one place. They're easier for computers and humans to find. While AppVeyor can be configured to sweep them up, and so can FakeItEasy's "sweep up artifacts on build failure" script, having them all appear under |
It's all good. No harm done, and all three of us failed to notice the change in behaviour. |
Thanks @blairconrad |
This change has been released in FakeItEasy 5.0.0. |
Connects to #1520.