update build tools #1612
Merged
update build tools #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bullseye 3.0.0-beta.3 - SimpleExec 6.1.0-beta.1
This was referenced Sep 1, 2019
blairconrad
approved these changes
Sep 1, 2019
|
Thanks, @adamralph. I read the changes, and they sound good. The only difference I see is the change from "Bullseye" to "FakeItEasy.Build" on the console, which seems good. I don't see a problem moving the output to stderr. |
thomaslevesque
approved these changes
Sep 2, 2019
There was a problem hiding this comment.
Looks good to me too, thanks @adamralph !
The only difference I see is the change from "Bullseye" to "FakeItEasy.Build" on the console, which seems good
I love that change! Just yesterday I was thinking it would be nice to have something other than "Bullseye".
|
This change has been released as part of FakeItEasy 5.2.0. Thanks, @adamralph. Look for your name in the release notes! 🏆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd love to get your feedback on these changes. They are mainly cosmetic: a bunch of logging tweaks. In the case of Bullseye, a few of the changes are marked
breakingbut purely because the logging was previously done to stdout, so theoretically the output could have been being piped to another program and parsed. All logging is done to stderr now.