Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests against netcoreapp3.0 #1634

Merged
merged 3 commits into from
Sep 29, 2019

Conversation

blairconrad
Copy link
Member

Fixes #1632.

@blairconrad blairconrad force-pushed the netcoreapp3.0 branch 2 times, most recently from 731a4b0 to 344d46e Compare September 29, 2019 13:55
@blairconrad blairconrad changed the title [WIP] Run tests against netcoreapp3.0 Run tests against netcoreapp3.0 Sep 29, 2019
@blairconrad blairconrad changed the title Run tests against netcoreapp3.0 [WIP] Run tests against netcoreapp3.0 Sep 29, 2019
@blairconrad blairconrad changed the title [WIP] Run tests against netcoreapp3.0 Run tests against netcoreapp3.0 Sep 29, 2019
@blairconrad
Copy link
Member Author

blairconrad commented Sep 29, 2019

Un-wipping because I can't find the warning anymore. Likely was introduced by my lack of proper properties assigned to the integration test project under netcoreapp3.0.
And now I notice I'm behind head. Repushing.

Copy link
Member

@thomaslevesque thomaslevesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @blairconrad!

@thomaslevesque thomaslevesque merged commit f4ce986 into FakeItEasy:master Sep 29, 2019
@blairconrad blairconrad added this to the vNext milestone Sep 29, 2019
@blairconrad blairconrad deleted the netcoreapp3.0 branch September 29, 2019 15:50
@blairconrad
Copy link
Member Author

Thank you!

@blairconrad blairconrad removed this from the vNext milestone Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates tests to also run against netcoreapp3.0
2 participants